Date: Fri, 14 Sep 2018 11:12:37 -0400 From: "Jason E. Hale" <jhale@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Yuri Victorovich <yuri@freebsd.org>, ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, jbeich@freebsd.org Subject: Re: svn commit: r479762 - head/science/cp2k Message-ID: <CAJE75NHaNbcMttz4zk7QOu6FQghZ29z0fe1%2Bc603vw-hiRpqbg@mail.gmail.com> In-Reply-To: <20180914102558.e4tuqrxeu7jvyyu4@atuin.in.mat.cc> References: <201809140758.w8E7w5D9093846@repo.freebsd.org> <20180914102558.e4tuqrxeu7jvyyu4@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 14, 2018 at 6:26 AM Mathieu Arnold <mat@freebsd.org> wrote:
>
> On Fri, Sep 14, 2018 at 07:58:05AM +0000, Yuri Victorovich wrote:
> > +.include <bsd.port.options.mk>
> > +
> > +.if ${PORT_OPTIONS:MOPENMP} || ${PORT_OPTIONS:MOPENMP_MPI}
> > +pre-configure:
> > + @if [ ! -e ${LOCALBASE}/lib/libfftw3_omp.so ] ; then \
> > + ${ECHO_MSG} "The OPENMP and OPENMP_MPI options require math/fftw3" ; \
> > + ${ECHO_MSG} "to be built and installed with the OPENMP option ON" ; \
> > + exit 1; \
> > + fi
> > +.endif
>
> I keep wondering why you always try so hard to invent new ways of doing
> things.
>
> .if ${PORT_OPTIONS:MOPENMP} || ${PORT_OPTIONS:MOPENMP_MPI}
> . if !exists(${LOCALBASE}/lib/libfftw3_omp.so)
> BROKEN= The OPENMP and OPENMP_MPI options require math/fftw3 to be built and installed with the OPENMP option ON
> . endif
> .endif
>
Don't blame him, mat. The suggestion was mine. I actually got the idea
from antoine@: https://svnweb.freebsd.org/ports?view=revision&revision=406268.
If BROKEN is set, unless the user knows or wants to pass the -T flag
to poudriere, it will not attempt the build in bulk mode even if the
user has the correct options for fftw3 set. Your condition is always
true in a clean environment.
- Jason
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NHaNbcMttz4zk7QOu6FQghZ29z0fe1%2Bc603vw-hiRpqbg>