Date: Thu, 07 Jun 2001 14:24:39 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: mjacob@feral.com, dfr@nlsystems.com, freebsd-alpha@FreeBSD.org Subject: RE: CFR: db_trace.c from NetBSD Message-ID: <XFMail.010607142439.jhb@FreeBSD.org> In-Reply-To: <15135.58046.974661.129491@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07-Jun-01 Andrew Gallatin wrote: > > I'd like to update our db_trace.c to use Ross Harvey's clever > NetBSD traceback methods. > > The advantages are that we get a _lot_ more info. Yes please. The only comments I would make is that I would not remove the check that bounds the count at 65535 for the default case (so that if you hit a loop it will terminate at 65535 frames not 2 billion frames). Once this is committed I will probably change the way the have_addr branch works to be identical to that on the x86 (just trace pid, not trace tpid). This looks great. Thanks! -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010607142439.jhb>