Date: Fri, 18 Apr 2025 08:29:19 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: freebsd-net@freebsd.org Subject: Re: merge traceroute6 into traceroute Message-ID: <86ikn26kzk.fsf@ltc.des.dev> In-Reply-To: <aAGESAWvFmFrLR9s@hemlock.eden.le-fay.org> (Lexi Winter's message of "Thu, 17 Apr 2025 23:44:24 %2B0100") References: <Z_f9mXz9_oTxJO8R@hemlock.eden.le-fay.org> <86ikn5b99w.fsf@ltc.des.dev> <aAGESAWvFmFrLR9s@hemlock.eden.le-fay.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Lexi Winter <lexi@hemlock.eden.le-fay.org> writes: > Dag-Erling Smørgrav <des@freebsd.org> writes: > > Lexi Winter <lexi@hemlock.eden.le-fay.org> writes: > > > i have proposed a patch to merge traceroute6 into traceroute [...] > > I've only skimmed the PR but I urge you to look at sbin/ping/main.c and > > adjust your code to match. > i think you're essentially proposing what jlduran@ already proposed in > the PR. No. Please actually look at ping, particularly how it's handling DNS lookups. And please separate code from variable definitions, this isn't 1967 and you're not about to run out of paper in your teletype. DES -- Dag-Erling Smørgrav - des@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ikn26kzk.fsf>