Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 4 Aug 2020 02:20:15 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r363821 - head/contrib/googletest/googletest/test
Message-ID:  <202008040220.0742KFjf056485@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: kevans
Date: Tue Aug  4 02:20:15 2020
New Revision: 363821
URL: https://svnweb.freebsd.org/changeset/base/363821

Log:
  Re-enable disabled googletest-port-test tests after r363820
  
  gtest now links against libregex here, and the tests pass locally.
  
  PR:		248452

Modified:
  head/contrib/googletest/googletest/test/googletest-port-test.cc

Modified: head/contrib/googletest/googletest/test/googletest-port-test.cc
==============================================================================
--- head/contrib/googletest/googletest/test/googletest-port-test.cc	Tue Aug  4 02:18:24 2020	(r363820)
+++ head/contrib/googletest/googletest/test/googletest-port-test.cc	Tue Aug  4 02:20:15 2020	(r363821)
@@ -403,8 +403,6 @@ typedef testing::Types<
 TYPED_TEST_CASE(RETest, StringTypes);
 
 // Tests RE's implicit constructors.
-/*
-https://bugs.freebsd.org/248452
 TYPED_TEST(RETest, ImplicitConstructorWorks) {
   const RE empty(TypeParam(""));
   EXPECT_STREQ("", empty.pattern());
@@ -415,7 +413,6 @@ TYPED_TEST(RETest, ImplicitConstructorWorks) {
   const RE normal(TypeParam(".*(\\w+)"));
   EXPECT_STREQ(".*(\\w+)", normal.pattern());
 }
-*/
 
 // Tests that RE's constructors reject invalid regular expressions.
 TYPED_TEST(RETest, RejectsInvalidRegex) {
@@ -864,8 +861,6 @@ TEST(MatchRegexAnywhereTest, ReturnsTrueWhenMatchingNo
 }
 
 // Tests RE's implicit constructors.
-/*
-https://bugs.freebsd.org/248452
 TEST(RETest, ImplicitConstructorWorks) {
   const RE empty("");
   EXPECT_STREQ("", empty.pattern());
@@ -873,7 +868,6 @@ TEST(RETest, ImplicitConstructorWorks) {
   const RE simple("hello");
   EXPECT_STREQ("hello", simple.pattern());
 }
-*/
 
 // Tests that RE's constructors reject invalid regular expressions.
 TEST(RETest, RejectsInvalidRegex) {

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008040220.0742KFjf056485>