Date: Sun, 19 Aug 2018 12:27:34 -0600 From: Ian Lepore <ian@freebsd.org> To: Xin LI <delphij@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338059 - in head: . contrib/ntp/lib/isc contrib/ntp/sntp/libevent crypto/heimdal/lib/roken crypto/openssh include lib/libc/gen lib/libc/include sys/crypto/chacha20 Message-ID: <1534703254.27158.41.camel@freebsd.org> In-Reply-To: <201808191740.w7JHeoSj052259@repo.freebsd.org> References: <201808191740.w7JHeoSj052259@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2018-08-19 at 17:40 +0000, Xin LI wrote: > Author: delphij > Date: Sun Aug 19 17:40:50 2018 > New Revision: 338059 > URL: https://svnweb.freebsd.org/changeset/base/338059 > > Log: > Update userland arc4random() with OpenBSD's Chacha20 based > arc4random(). > > ObsoleteFiles.inc: > > Remove manual pages for arc4random_addrandom(3) and > arc4random_stir(3). > > contrib/ntp/lib/isc/random.c: > contrib/ntp/sntp/libevent/evutil_rand.c: > > Eliminate in-tree usage of arc4random_addrandom(). > If we don't feed changes for this back upstream, we're going to have to carry diffs from mainline ntpd forever now. The upstream project is receptive to taking diffs from us, but I guess we'd have to figure out how to write some autotools detection to create some new HAVE_xxxx variables for wrapping these calls. Also, does this imply that the ntpd port will fail to build now? I would imagine removing such fundamental routines would affect many ports. All in all, if it's just a matter of our implementation not needing these functions, wouldn't it be better to implement them as no-ops and document them as such existing only to aid porting existing code? -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1534703254.27158.41.camel>