Date: Sat, 11 May 2019 10:35:09 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Doug Moore <unkadoug@gmail.com>, Cy Schubert <Cy.Schubert@cschubert.com>, Doug Moore <dougm@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347477 - head/sys/kern Message-ID: <4dbd3d4b-3d6c-d0b0-e6a7-8c80997124dd@FreeBSD.org> In-Reply-To: <a5861276-9954-9185-fa75-ee0df8c3576e@gmail.com> References: <201905110447.x4B4lqeh031565@slippy.cwsent.com> <a5861276-9954-9185-fa75-ee0df8c3576e@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi; On 10/05/2019 23:57, Doug Moore wrote: > With mentor approval, I commit r347469. I start getting email about > jenkins failure to build for several architectures on account of the > _Generic() construct I introduced in that change. > > I whip up a patch to undo that part of r347469, and ask for mentor > approval. Meanwhile, mentor authorizes me in email to revert r347469. > > I try apply applying the fix-patch, and get email that it was rejected > for lack of reviewer. In retrospect, it seems to have been committed > anyway as r347472. > > Thinking that things are still broken, I do what my mentor pre-approved > earlier and revert back to before r347469. A patch to redo r347469, > without _Generic(), awaits mentor approval. Ugh... a rather elegant interaction ;) > I realize that breaking the build and then committing without mentor > approval in my first week as committer isn't a good beginning. Sorry > about that. It's probably not official policy but I would think you don't need mentor approval to revert a change, assuming things return to the pre-commit state, especially if it broke the build. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4dbd3d4b-3d6c-d0b0-e6a7-8c80997124dd>