Date: Tue, 20 Nov 2007 14:24:46 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: John Birrell <jb@what-creek.com> Cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/lib/libkse Makefile src/lib/libthr Makefile src/usr.bin/netstat Makefile src/usr.sbin/acpi/acpidb Makefile src/usr.sbin/kldxref Makefile src/usr.sbin/nscd Makefile src/usr.sbin/rpc.yppasswdd Makefile Message-ID: <8663zxcan5.fsf@ds4.des.no> In-Reply-To: <20071120093155.GA6959@what-creek.com> (John Birrell's message of "Tue\, 20 Nov 2007 09\:31\:55 %2B0000") References: <200711200207.lAK27UmF082244@repoman.freebsd.org> <20071120082329.C53707@maildrop.int.zabbadoz.net> <20071120093155.GA6959@what-creek.com>
next in thread | previous in thread | raw e-mail | index | archive | help
John Birrell <jb@what-creek.com> writes: > The thing that I take issue with is holding off re-enabling the WARNS > -Werror checks which used to serve us well simply because there are > custom CFLAGS set on the tinderboxes which cause non-fatal errors > that nobody _ever_ _looks_ _at_. The errors are non-fatal because > -Werror was disabled. The errors are serious and should be fixed. They represent *actual bugs* or at the very least serious design issues in the code. Nobody benefits from sweeping them under the rug. The reason why nobody looks at them is *precisely* the fact that they don't stop the build. This is *precisely* why I disapprove of the use of -fno-strict-aliasing. > As an exercise to the readers of this message, please take a look > at src/lib/libthr, our preferred threading library. libthr has serious aliasing issues which I have commented on before. I will not discuss them further on a public list. > I would prefer that the tinderboxes run with the same defaults that > we have in CVS, however, from what I have seen today, I think that we > may need to rethink our defaults. I have said this repeatedly in the past. Perhaps someone will listen when it isn't me saying it? DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8663zxcan5.fsf>