Date: Sun, 05 Dec 2004 14:16:38 -0800 From: Nate Lawson <nate@root.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c Message-ID: <41B388C6.5090409@root.org> In-Reply-To: <20041204.221541.115654786.imp@bsdimp.com> References: <200412050135.iB51ZJJl040909@repoman.freebsd.org> <20041204.221541.115654786.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
M. Warner Losh wrote: > In message: <200412050135.iB51ZJJl040909@repoman.freebsd.org> > Nate Lawson <njl@FreeBSD.org> writes: > : If we are resuming non-MPSAFE drivers, they need Giant held for them. > > Generally, when walking the device tree, one must have Giant. I've > been meaning to add asserts for this in the tree... I think that we > have enough things giant is pushed out of that it is time... I'd like that. I think the GIANT_REQUIRED asserts should go in the root_bus suspend/resume/shutdown methods, not in acpi. This will cover everyone unless a driver drops Giant and doesn't reacquire it (unlikely). -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41B388C6.5090409>