Date: Mon, 27 Nov 2006 13:34:56 +0000 From: Florent Thoumie <flz@FreeBSD.org> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr Message-ID: <456AE980.6020304@FreeBSD.org> In-Reply-To: <20061127130323.GC77085@comp.chem.msu.su> References: <200611261903.kAQJ3KPp013911@repoman.freebsd.org> <20061127130323.GC77085@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBB024FD9DE47686CE4CE7033 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Yar Tikhiy wrote: > On Sun, Nov 26, 2006 at 07:03:20PM +0000, Florent Thoumie wrote: >> flz 2006-11-26 19:03:19 UTC >> >> FreeBSD src repository >> >> Modified files: >> etc rc.subr=20 >> Log: >> Remove leading dollar sign in rcvar command output. >> There's no dollar use in variable assignment in sh. >> Assuming this is can be expected behavior for some >> people, this change won't be MFC'ed to RELENG_6. >> =20 >> Discussed with: yar on -rc >> =20 >> Revision Changes Path >> 1.70 +2 -2 src/etc/rc.subr >=20 > Such one-character bogosities are an eyesore but they often take > enormous effort to be fixed because of complications they have. > It's no surprise they usually live forever. Thanks for starting > the fight against this one! >=20 > By the way, now the output follows the NetBSD rc.conf style: >=20 > # $foo_enable > foo_enable=3DYES >=20 > Could it be changed even further to match our own rc.conf style? > I.e.: >=20 > # $foo_enable > foo_enable=3D"YES" Yeah, makes sense. There's also a patch in gnats to add a 'enable/disable' command to rc.subr. I'll try to have a look. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enigBB024FD9DE47686CE4CE7033 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFaumMMxEkbVFH3PQRCj0qAJ9ksEfPaagTqjDSRXBvM9MFmPHkSwCggS0a H6W5AB0lEbR8MGBZwmz9zro= =e+rT -----END PGP SIGNATURE----- --------------enigBB024FD9DE47686CE4CE7033--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?456AE980.6020304>