Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Jan 2026 08:55:24 +0100 (CET)
From:      Ronald Klop <ronald-lists@klop.ws>
To:        Craig Leres <leres@freebsd.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, dev-commits-ports-all@FreeBSD.org
Subject:   Re: git: b6b8d5fbd97b - main - devel/arduino: pin to openjdk8
Message-ID:  <1327629307.91.1769154924028@localhost>
In-Reply-To: <e615b5c8-266c-4c47-a263-75183ce9e482@freebsd.org>
References:  <6972aba9.39b68.5b3bcaab@gitrepo.freebsd.org> <e615b5c8-266c-4c47-a263-75183ce9e482@freebsd.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
Van: Craig Leres <leres@freebsd.org>
Datum: vrijdag, 23 januari 2026 00:02
Aan: Ronald Klop <ronald@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Onderwerp: Re: git: b6b8d5fbd97b - main - devel/arduino: pin to openjdk8
> 
> On 1/22/26 14:58, Ronald Klop wrote:
> > The branch main has been updated by ronald:
> >
> > URL:https://cgit.FreeBSD.org/ports/commit/? > id=b6b8d5fbd97bcb931fb53e9d7bbd71622ae5e482
> >
> > commit b6b8d5fbd97bcb931fb53e9d7bbd71622ae5e482
> > Author:     Ronald Klop<ronald@FreeBSD.org>
> > AuthorDate: 2026-01-22 15:47:58 +0000
> > Commit:     Ronald Klop<ronald@FreeBSD.org>
> > CommitDate: 2026-01-22 22:58:16 +0000
> >
> >      devel/arduino: pin to openjdk8
> >      
> >      Dependency comms/rxtx is tied to openjdk8 and installs jars in
> >      PREFIX/openjdk8/jre/lib/ext. This directory is gone in jdk9+, but
> >      arduino expects it.
> >      So pin arduino to openjdk8 also.
> >      If anybody wants this to be supported by jdk9+, patches are welcome.
> >      
> >      PR:     292651
> 
> If it was me I would have added:
> 
>      Approved by: leres (maintainer)
> 
>         Craig
> 
> 
> 


Hi Craig,

Sorry I didn't mention you. My thinking was that the approval is already registered in the PR. So mentioning the PR documents your approval.

Regards,
Ronald.
 
[-- Attachment #2 --]
<html><head></head><body><br>
<p><strong>Van:</strong> Craig Leres &lt;leres@freebsd.org&gt;<br>
<strong>Datum:</strong> vrijdag, 23 januari 2026 00:02<br>
<strong>Aan:</strong> Ronald Klop &lt;ronald@FreeBSD.org&gt;, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org<br>
<strong>Onderwerp:</strong> Re: git: b6b8d5fbd97b - main - devel/arduino: pin to openjdk8</p>

<blockquote style="padding-right: 0px; padding-left: 5px; margin-left: 5px; border-left: #000000 2px solid; margin-right: 0px">
<div class="MessageRFC822Viewer" id="P">
<div class="TextPlainViewer" id="P.P">On 1/22/26 14:58, Ronald Klop wrote:<br>
&gt; The branch main has been updated by ronald:<br>
&gt;<br>
&gt; URL:<a href="https://cgit.FreeBSD.org/ports/commit/">https://cgit.FreeBSD.org/ports/commit/</a>? &gt; id=b6b8d5fbd97bcb931fb53e9d7bbd71622ae5e482<br>
&gt;<br>
&gt; commit b6b8d5fbd97bcb931fb53e9d7bbd71622ae5e482<br>
&gt; Author: &nbsp;&nbsp;&nbsp;&nbsp;Ronald Klop&lt;ronald@FreeBSD.org&gt;<br>
&gt; AuthorDate: 2026-01-22 15:47:58 +0000<br>
&gt; Commit: &nbsp;&nbsp;&nbsp;&nbsp;Ronald Klop&lt;ronald@FreeBSD.org&gt;<br>
&gt; CommitDate: 2026-01-22 22:58:16 +0000<br>
&gt;<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;devel/arduino: pin to openjdk8<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Dependency comms/rxtx is tied to openjdk8 and installs jars in<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;PREFIX/openjdk8/jre/lib/ext. This directory is gone in jdk9+, but<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;arduino expects it.<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;So pin arduino to openjdk8 also.<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;If anybody wants this to be supported by jdk9+, patches are welcome.<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;PR: &nbsp;&nbsp;&nbsp;&nbsp;292651<br>
<br>
If it was me I would have added:<br>
<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Approved by: leres (maintainer)<br>
<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Craig</div>

<hr></div>
</blockquote>
<br>
<br>
Hi Craig,<br>
<br>
Sorry I didn't mention you. My thinking was that the approval is already registered in the PR. So mentioning the PR documents your approval.<br>
<br>
Regards,<br>
Ronald.<br>
&nbsp;</body></html>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1327629307.91.1769154924028>