Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Sep 2019 14:06:39 -0000
From:      Chris Rees <crees@bayofrum.net>
To:        rgrimes@freebsd.org, "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>, Andriy Gapon <avg@freebsd.org>
Cc:        "O. Hartmann" <ohartmann@walstatt.org>, Chris Rees <crees@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r346017 - in head: libexec/rc libexec/rc/rc.d share/man/man5
Message-ID:  <A35301AC-C3A4-478A-8D4A-99E97D1CB8C6@bayofrum.net>
In-Reply-To: <201904091955.x39Jt7PU061907@gndrsh.dnsmgr.net>
References:  <201904091955.x39Jt7PU061907@gndrsh.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help


On 9 April 2019 20:55:07 BST, "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net=
> wrote:
>> On 09/04/2019 21:33, Rodney W. Grimes wrote:
>> > I think the trigger issue is:
>> > grep zfs /etc/rc.d/zvol=20
>> > rcvar=3D"zfs_enable"
>> > required_modules=3D"zfs"
>> >=20
>> > that module requires may be going south with the
>> > new code when the module is built into the kernel.
>>=20
>> Maybe it's because the module's name is zfsctrl (for whatever reason)
>while the
>> module file is named zfs.ko.
>
>I suspect that could also lead to issues with the new code.
>It seems to be failing to detect that zfs is infact functional in the
>kernel,
>and blindly, or not so blindly, trying to load zfs,ko, which when you
>build
>it into the kernel you usually do so without any modules built, so
>there is
>no /boot/kernel/zfs.ko, and even if you did build it any attempt to
>load
>it would return an error.

Loading with it built in isn't a problem, as I showed earlier.

Loading when it doesn't exist *is*.

I'm torn.  Either we could revert this, or add a check to the required_modu=
les function instead, which I think is the better solution.

Chris
--=20
Sent from my Android device with K-9 Mail. Please excuse my brevity.

--=20
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A35301AC-C3A4-478A-8D4A-99E97D1CB8C6>