Date: Sun, 22 Mar 2009 18:15:49 -0500 (CDT) From: Mike Silbersack <silby@silby.com> To: Robert Watson <rwatson@FreeBSD.org> Cc: svn-src-stable-7@freebsd.org, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, Mike Silbersack <silby@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r190299 - stable/7/sys/kern Message-ID: <alpine.BSF.2.00.0903221814240.29638@odysseus.silby.com> In-Reply-To: <alpine.BSF.2.00.0903222305120.85640@fledge.watson.org> References: <200903222300.n2MN00IO086771@svn.freebsd.org> <alpine.BSF.2.00.0903222305120.85640@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 22 Mar 2009, Robert Watson wrote: > On Sun, 22 Mar 2009, Mike Silbersack wrote: > >> Fix unp_gc so that it recognizes file descriptors >> that are currently in the process of being passed >> between processes as alive and does not >> try to garbage collect them. >> >> The full description of the problem and a test >> program to reproduce it can be found in PR 112554. >> >> This fix was inspired by similar fixes in NetBSD and BSD/OS. >> However, it does not apply to FreeBSD 8 and above - >> when this code was rewritten and optimized, the bug >> was fixed in a different way. The test program in the >> PR passes on 8-current with flying colors. > > We have a UNIX domain socket-passing regression test that creates various > contortion-esque situations and then looks to see if sockets were leaked. If > it doesn't yet capture this failure mode, could you add it to that test? > > Robert N M Watson > Computer Laboratory > University of Cambridge I've been meaning to do that for two years, that's what delayed me from committing this. I finally decided to get it in before I missed another release. So I can try, but I won't make any guarantees. Mike "Silby" Silbersack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0903221814240.29638>