Date: Wed, 05 Dec 2012 06:00:56 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: loos.br@gmail.com Cc: freebsd-arch@FreeBSD.org Subject: Re: FDT Support for GPIO (gpiobus and friends) Message-ID: <20121205.060056.592894859995638978.hrs@allbsd.org> In-Reply-To: <BEB9A0F8-560B-4937-8707-653988A26D85@gmail.com> References: <BEB9A0F8-560B-4937-8707-653988A26D85@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Wed_Dec__5_06_00_56_2012_562)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Luiz Otavio O Souza <loos.br@gmail.com> wrote
in <BEB9A0F8-560B-4937-8707-653988A26D85@gmail.com>:
lo> Hi,
lo>
lo> I've been playing with GPIO on RPi and found the missing support of
lo> FDT on gpiobus very annoying.
lo>
lo> The following patch (gpio-fdt.diff) adds FDT support to GPIO (gpiobus,
lo> gpioc, gpioled).
lo>
lo> The bcm2835_gpio.c.fdt.diff will add (a better) support of FDT on RPi
lo> GPIO controller and the bcm2835.dts.diff has my changes on the RPi dts
lo> for adding support of gpioled on 'ok' led (pin 16).
lo>
lo> Comments ?
I like this idea, but it should be consistent with standard device
tree bindings. For example,
+ gpiobus {
+ compatible = "gpiobus";
+
+ /* Ok led */
+ led {
+ compatible = "gpioled";
+ label = "ok";
+ pins = <16>;
+ };
+ };
should be something like the following:
led {
compatible = "gpio-leds";
ok {
gpios = <&foo 16 1>;
label = "ok";
};
};
A node using GPIOs must have gpios property for the gpio-controller
node and pin number.
-- Hiroki
----Security_Multipart(Wed_Dec__5_06_00_56_2012_562)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iEYEABECAAYFAlC+ZIgACgkQTyzT2CeTzy11aACdGlsC5wkywjh7b7i22FeEhgLU
2UUAn20D8iJiexPsVsSHTOjO8w5EbTXG
=3KTu
-----END PGP SIGNATURE-----
----Security_Multipart(Wed_Dec__5_06_00_56_2012_562)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121205.060056.592894859995638978.hrs>