Date: Wed, 27 Sep 2000 12:00:24 +0900 From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: msmith@freebsd.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpi acpi.c acpi.h acpi_powerres.c Message-ID: <20000927120024D.iwasaki@jp.FreeBSD.org> In-Reply-To: <200009270147.e8R1luA02496@mass.osd.bsdi.com> References: <200009270140.SAA01482@freefall.freebsd.org> <200009270147.e8R1luA02496@mass.osd.bsdi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> This and some other issues with the last couple of commits in the ACPI > code have me a little worried. > > None of these should have been left enabled. The current default takes > at least one (maybe three) ACPI interrupts per keystroke, and logs them > all to the console (and syslog). Thanks a lot mike! > Also, acpi.c and friends have some massive style and cleanliness > problems. I'd like to take a major whitespace/style cleanup through at > least acpi.? and acpi_powerres.? soon, but I don't want to upset others > by generating huge diffs against their work. > > Iwasaki-san, can you suggest a good time to do this? I'm not so worried > about the aml interpreter, but this code needs a *serious* cleanup, and > probably some more splitting out before it gets much older. I'd also > like to ask people to be a bit tidier when working around here. Yes, please do. As far as I know, it's good timing to do this. Watanabe-san and I have just committed our recent work, and experimental porting to NetBSD by someone (based on the code as of early Sept.) have just finished and they're evaluating it now. After your mega cleanup, we can merge NetBSD guy's effort. Thanks To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000927120024D.iwasaki>