Date: Mon, 1 Dec 2008 05:25:54 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Dag-Erling Sm??rgrav <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Tim Kientzle <kientzle@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r185499 - head Message-ID: <20081201132554.GD27096@elvis.mu.org> In-Reply-To: <863ah8rvcd.fsf@ds4.des.no> References: <200812010045.mB10jpmX007146@svn.freebsd.org> <49338E98.7020104@freebsd.org> <863ah8rvcd.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dag-Erling Sm??rgrav <des@des.no> [081201 03:25] wrote:
> Tim Kientzle <kientzle@freebsd.org> writes:
> > Alfred Perlstein <alfred@freebsd.org> writes:
> > > Log:
> > > Provide a 'tinderbox' target that compiles enough of FreeBSD that
> > > a developer can rest reasonably assured that the tinderbox will not
> > > be broken. This target leverages most of 'universe' but will exit
> > > non-zero and output a summary at the end.
> > > "make tinderbox"
> > Excellent!
>
> I really don't see the point, especially now that 'make universe' will
> issue a warning on stdout for every build that fails. As I've tried to
> explain to Alfred, the tinderbox does nothing magical, and nothing that
> isn't already covered by 'make universe'. I also asked him to discuss
> any changes with Poul-Henning before committing them.
I'll summarize the changes here:
Problems with make universe:
1) Make universe returns success on failure.
2) Make universe outputs the following on failure:
--------------------------------------------------------------
make universe completed on `LC_ALL=C date`"
(started ${STARTTIME})"
--------------------------------------------------------------
This basically means you can't chain 'make universe' into something
like "make tinderbox || (echo oops | mail -s tinderbox failed...)".
The summary at the end "completed" is very misleading.
The tinderbox target differs as follows:
It returns an error if it fails.
It outputs a summary of the failures at the end.
The name reflects what its for. ("what the heck is a universe?")
If you strongly believe that a target should return "true" on failure
and/or output "i worked" on failure then I'm not sure how to approach
that mindset, maybe you can help me understand where you're coming from
on that? Where is the utility in it? Is there something I'm missing?
thanks,
-Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081201132554.GD27096>