Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Dec 2002 12:58:49 -0800
From:      Alfred Perlstein <bright@mu.org>
To:        Matt Dillon <dillon@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/vm vm.h src/sys/kern imgact_elf.c src/libexec/rtld-elf map_object.c
Message-ID:  <20021216205849.GV23663@elvis.mu.org>
In-Reply-To: <200212161924.gBGJOhSb048310@repoman.freebsd.org>
References:  <200212161924.gBGJOhSb048310@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* Matt Dillon <dillon@FreeBSD.org> [021216 11:24] wrote:
> dillon      2002/12/16 11:24:43 PST
> 
>   Modified files:
>     sys/vm               vm.h 
>     sys/kern             imgact_elf.c 
>     libexec/rtld-elf     map_object.c 
>   Log:
>   Change the way ELF coredumps are handled.  Instead of unconditionally
>   skipping read-only pages, which can result in valuable non-text-related
>   data not getting dumped, the ELF loader and the dynamic loader now mark
>   read-only text pages NOCORE and the coredump code only checks (primarily) for
>   complete inaccessibility of the page or NOCORE being set.
>   
>   Certain applications which map large amounts of read-only data will
>   produce much larger cores.  A new sysctl has been added,
>   debug.elf_legacy_coredump, which will revert to the old behavior.
>   
>   This commit represents collaborative work by all parties involved.
>   The PR contains a program demonstrating the problem.

Wouldn't it make sense to automagically OR in NOCORE when calling mmap
for readonly, but when madvise is called _then_ turn off NOCORE?

-- 
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
 start asking why software is ignoring 30 years of accumulated wisdom.'

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021216205849.GV23663>