Date: Fri, 17 Jan 2014 13:54:23 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r340026 - head/net-im/libpurple Message-ID: <20140117125423.GE79245@ithaqua.etoilebsd.net> In-Reply-To: <20140117124521.GF4006@gahrfit.gahr.ch> References: <201401171033.s0HAX99I020937@svn.freebsd.org> <884B7C619AAEEC285129466D@atuin.in.mat.cc> <20140117124521.GF4006@gahrfit.gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
--WBsA/oQW3eTA3LlM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Jan 17, 2014 at 01:45:21PM +0100, Pietro Cerutti wrote:
> On 2014-Jan-17, 11:47, Mathieu Arnold wrote:
> > +--On 17 janvier 2014 10:33:09 +0000 Pietro Cerutti <gahr@FreeBSD.org>
> > wrote:
> > | .if ${PORT_OPTIONS:MTCLTK}
> > | -USE_TK=3D yes
> > | -CFLAGS+=3D -I${LOCALBASE}/include/tk${TK_VER}
> > | -I${LOCALBASE}/include/tcl${TCL_VER} -CONFIGURE_ARGS+=3D
> > | --with-tclconfig=3D${LOCALBASE}/lib/tcl${TCL_VER} \ -
> > | --with-tkconfig=3D${LOCALBASE}/lib/tk${TK_VER}
> > | +USES+=3D tk
> > | +CFLAGS+=3D -I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR}
> > | +CONFIGURE_ARGS+=3D --with-tclconfig=3D${TCL_LIBDIR} \
> > | + --with-tkconfig=3D${TK_LIBDIR}
> >=20
> > Which is way better written as :
> >=20
> > TCLTK_USES=3D tk
> > TCLTK_CFLAGS=3D -I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR}
> > TCLTK_CONFIGURE_ON=3D --with-tclconfig=3D${TCL_LIBDIR} \
> > --with-tkconfig=3D${TK_LIBDIR}
>=20
> Nice framework. But given that I have to enclose stuff in
> .if ${PORT_OPTIONS:MTCLTK}=20
> anyway because of PLIST_SUB and CONFIGURE_ARGS, what's the benefit?
>=20
No you don't
CONFIGURE_ARGS is TCLTK_CONFIGURE_*
PLIST_SUB can be replaced by OPTIONS_SUB (which will create all the need
@comment
regards,
Bapt
--WBsA/oQW3eTA3LlM
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (FreeBSD)
iEYEARECAAYFAlLZJ/8ACgkQ8kTtMUmk6EwrsgCguxxkevwPW5NDG+mSSRFzIbn7
uFsAn2ztbafs+uPZuJkU4oeZKSTbGARM
=y1pI
-----END PGP SIGNATURE-----
--WBsA/oQW3eTA3LlM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140117125423.GE79245>