Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Jul 2020 17:27:29 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 248213] TCP BBR - Two  FINs with same seq number are seen in simultaneous close
Message-ID:  <bug-248213-227-ZJLcAR1RSF@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-248213-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-248213-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248213

--- Comment #2 from Hitesh <maisheri.hitesh@gmail.com> ---
The following block  of code is what causing the non-conformance with RFC.
Also, the validation for FIN flag here is redundant.

                        if (flags & TH_FIN && tp->t_flags & TF_SENTFIN) {
                                /*
                                 * If we sent the fin already its 1 minus
                                 * snd_max
                                 */
                                th->th_seq =3D (htonl(tp->snd_max - 1));
                                bbr_seq =3D (tp->snd_max - 1);
                        } else {
                                /* First time FIN use snd_max */
                                th->th_seq =3D htonl(tp->snd_max);
                                bbr_seq =3D tp->snd_max;
                        }

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248213-227-ZJLcAR1RSF>