Date: Tue, 13 Apr 2004 19:15:26 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Tim Kientzle <kientzle@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/tar bsdtar.c bsdtar.h write.c Message-ID: <20040414021526.GB63832@elvis.mu.org> In-Reply-To: <200404140040.i3E0esil061104@repoman.freebsd.org> References: <200404140040.i3E0esil061104@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
While I applaud the effort here, it is a major violation of C POLA to have compilable code within a header file. I think you should basically move all the variables instantiated in bsdtar.h to their appropriate .c files. thank you, -Alfred * Tim Kientzle <kientzle@FreeBSD.org> [040413 17:41] wrote: > kientzle 2004/04/13 17:40:54 PDT > > FreeBSD src repository > > Modified files: > usr.bin/tar bsdtar.c bsdtar.h write.c > Log: > A simple cache of uid->uname lookups and gid->gname lookups eliminates > almost 1/2 of the CPU time required to create an uncompressed archive > and makes a noticable reduction in wallclock time. > > Revision Changes Path > 1.6 +11 -0 src/usr.bin/tar/bsdtar.c > 1.3 +14 -0 src/usr.bin/tar/bsdtar.h > 1.7 +35 -12 src/usr.bin/tar/write.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040414021526.GB63832>