Date: Tue, 16 Sep 2008 16:23:56 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/ufs/ufs dirhash.h ufs_dirhash.c Message-ID: <200809161624.m8GGO5bp074340@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jhb 2008-09-16 16:23:56 UTC
FreeBSD src repository
Modified files:
sys/ufs/ufs dirhash.h ufs_dirhash.c
Log:
SVN rev 183080 on 2008-09-16 16:23:56Z by jhb
Fix a race with shared lookups on UFS. If the the dirhash code reached the
cap on memory usage, then shared LOOKUP operations could start free'ing
dirhash structures. Without these fixes, concurrent free's on the same
directory could result in one of the threads blocked on a lock in a dirhash
structure free'd by the other thread.
- Replace the lockmgr lock in the dirhash structure with an sx lock.
- Use a reference count managed with ufsdirhash_hold()/drop() to determine
when to free the dirhash structures. The directory i-node holds a
reference while the dirhash is attached to an i-node. Code that wishes
to lock the dirhash while holding a shared vnode lock must first
acquire a private reference to the dirhash while holding the vnode
interlock before acquiring the dirhash sx lock. After acquiring the sx
lock, it drops the private reference after checking to see if the
dirhash is still used by the directory i-node.
Revision Changes Path
1.7 +5 -1 src/sys/ufs/ufs/dirhash.h
1.25 +82 -33 src/sys/ufs/ufs/ufs_dirhash.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809161624.m8GGO5bp074340>