Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Sep 2025 18:31:10 GMT
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 5e49712ca8fe - main - iwm: assign sequence numbers even if we ask the firmware to override
Message-ID:  <202509211831.58LIVA4w024223@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by adrian:

URL: https://cgit.FreeBSD.org/src/commit/?id=5e49712ca8fef53262f2f6769c119f27e0e175ee

commit 5e49712ca8fef53262f2f6769c119f27e0e175ee
Author:     Adrian Chadd <adrian@FreeBSD.org>
AuthorDate: 2025-09-21 17:21:34 +0000
Commit:     Adrian Chadd <adrian@FreeBSD.org>
CommitDate: 2025-09-21 18:30:46 +0000

    iwm: assign sequence numbers even if we ask the firmware to override
    
    I've had a report of this breaking without the sequence number
    assigned (from glebius@) so, similar to iwx work, let's just re-add
    it here.
    
    Reported by:    glebius
    Differential Revision:  https://reviews.freebsd.org/D52664
    Reviewed by:    glebius
    Tested by:      glebius
---
 sys/dev/iwm/if_iwm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sys/dev/iwm/if_iwm.c b/sys/dev/iwm/if_iwm.c
index 9f590f11864c..6840c6a4d00a 100644
--- a/sys/dev/iwm/if_iwm.c
+++ b/sys/dev/iwm/if_iwm.c
@@ -3773,6 +3773,10 @@ iwm_tx(struct iwm_softc *sc, struct mbuf *m, struct ieee80211_node *ni, int ac)
 
 	rinfo = iwm_tx_fill_cmd(sc, in, m, tx);
 
+	/* Offloaded sequence number assignment; non-AMPDU case */
+	if ((m->m_flags & M_AMPDU_MPDU) == 0)
+		ieee80211_output_seqno_assign(ni, -1, m);
+
 	/* Encrypt the frame if need be. */
 	if (wh->i_fc[1] & IEEE80211_FC1_PROTECTED) {
 		/* Retrieve key for TX && do software encryption. */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202509211831.58LIVA4w024223>