Date: Tue, 14 Aug 2001 00:00:17 -0700 (PDT) From: Larry Rosenman <ler@lerctr.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/26224 Message-ID: <200108140700.f7E70HE87217@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/26224; it has been noted by GNATS.
From: Larry Rosenman <ler@lerctr.org>
To: Thomas Moestl <tmoestl@gmx.net>
Cc: IA Network Engineering <neteng@airmail.net>,
Frank Durda IV <uhclem@airmail.net>, jamesn@airmail.net,
freebsd-gnats-submit@freebsd.org
Subject: Re: kern/26224
Date: Tue, 14 Aug 2001 01:53:09 -0500
* Larry Rosenman <ler@lerctr.org> [010725 19:05]:
> * Thomas Moestl <tmoestl@gmx.net> [010725 17:05]:
> > On Wed, 2001/07/25 at 16:49:52 -0500, Larry Rosenman wrote:
> > > * Thomas Moestl <tmoestl@gmx.net> [010725 13:11]:
> > > > On Wed, 2001/07/25 at 12:41:14 -0500, Larry Rosenman wrote:
> > > > > Any news on the kern/26224 bug?
> > > >
> > > > For -STABLE, the simplelocks can most probably just be removed
> > > > totally, so that this bug won't occur. For -CURRENT, this will need to
> > > > be done in a different way, but locking is in a state of flux there
> > > > anyway.
> > > >
> > > > Tor Egge had a patch to remove the locks, I'll ask him again if he
> > > > thinks that it is ready for commit.
> > > Thanks. The lockup version of this just bit me again. :-(
> > >
> > > I'm willing to be a guinea pig, if you need one.
> >
> > I have attached a patch I want to post to -stable soon for people to
> > test. I'm sure that it fixes this panic (the lock is just removed;
> > this section is also protected by the mp_lock, so it should be
> > safe). However, this is largely untested (I don't have an SMP box, and
> > on UP simplelocks are disabled). So, be warned, I could have
> > overlooked something, so other panics might surface...
> > On the other hand, you could probably test this patch well, because
> > your box seems rather stressed ;)
> Ok, it's applied, and booted. We'll see. This one seems to hit me
> every 3-4 weeks.
Even WITH this fix in, I just had the lockup version hit me.
Unfortunately, ctrl/break did *NOT* bring up DDB. The basic TCP stack
was working (ping, telnet got to the connected to xxx part), but the
box wouldn't give a login prompt nor serve www pages.
I don't know how to get the debug info.
The box was up for 19+ days (almost 20, not sure exactly).
How would you recomment proceeding?
>
> Thanks!
>
> LER
>
> >
> > - thomas
>
> > Index: vfs_subr.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sys/kern/vfs_subr.c,v
> > retrieving revision 1.249.2.9
> > diff -u -r1.249.2.9 vfs_subr.c
> > --- vfs_subr.c 2001/06/26 04:20:08 1.249.2.9
> > +++ vfs_subr.c 2001/07/25 21:35:01
> > @@ -730,12 +730,10 @@
> > /*
> > * Destroy the copy in the VM cache, too.
> > */
> > - simple_lock(&vp->v_interlock);
> > if (VOP_GETVOBJECT(vp, &object) == 0) {
> > vm_object_page_remove(object, 0, 0,
> > (flags & V_SAVE) ? TRUE : FALSE);
> > }
> > - simple_unlock(&vp->v_interlock);
> >
> > if (!TAILQ_EMPTY(&vp->v_dirtyblkhd) || !TAILQ_EMPTY(&vp->v_cleanblkhd))
> > panic("vinvalbuf: flush failed");
>
>
> --
> Larry Rosenman http://www.lerctr.org/~ler
> Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
> US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200108140700.f7E70HE87217>