Date: Sun, 21 Dec 1997 02:46:12 +1030 From: Mike Smith <mike@smith.net.au> To: Bruce Evans <bde@zeta.org.au> Cc: grog@lemis.com, julian@whistle.com, bde@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Bruce vandalism again Message-ID: <199712201616.CAA00301@word.smith.net.au> In-Reply-To: Your message of "Sat, 20 Dec 1997 19:39:50 %2B1100." <199712200839.TAA23072@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
> >I agree. This appears to be a seriously retrograde step. Bruce, why? > > I'm just enforcing this part of style(9): > > Only use the __P macro from the include file <sys/cdefs.h> if the source > file in general is (to be) compilable with a K&R Old testament compiler. > Use of the __P macro in new code is discouraged, although modifications > to existing files should be consistent with that file's conventions. > > In general code can be considered ``new code'' when it makes up about 50% > or more of the file[s] involved. This is enough to break precedents in > the existing code and use the current style guidelines. You are breaking your own rules, however, in performing a style-only commit. I think that we the great unwashed would much prefer to see you spend a few more minutes and infect the rest of the declarations in a given file with the ANSI bug rather than perform such a vindictively trivial retrogression. mike
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712201616.CAA00301>