Date: Fri, 14 Dec 2018 13:27:44 -0500 From: Jung-uk Kim <jkim@FreeBSD.org> To: Kevin Bowling <kevin.bowling@kev009.com>, koobs@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342057 - head/crypto/openssl/crypto/engine Message-ID: <e431b5b8-3a57-5562-b50e-21ed1246df4f@FreeBSD.org> In-Reply-To: <CAK7dMtCtK2HiWQr=cFXwUrP4TxZQD5b_nnNLXyYyk4PANWPAFQ@mail.gmail.com> References: <201812140106.wBE16Zgr058499@repo.freebsd.org> <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> <CAK7dMtCtK2HiWQr=cFXwUrP4TxZQD5b_nnNLXyYyk4PANWPAFQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1A1U1JfV4cX6yyHCJfcUXDapDfk0wZpCR Content-Type: multipart/mixed; boundary="ng2XUQsMXIXKkSe6k1YWneraSWUK6f9qD"; protected-headers="v1" From: Jung-uk Kim <jkim@FreeBSD.org> To: Kevin Bowling <kevin.bowling@kev009.com>, koobs@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <e431b5b8-3a57-5562-b50e-21ed1246df4f@FreeBSD.org> Subject: Re: svn commit: r342057 - head/crypto/openssl/crypto/engine References: <201812140106.wBE16Zgr058499@repo.freebsd.org> <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> <CAK7dMtCtK2HiWQr=cFXwUrP4TxZQD5b_nnNLXyYyk4PANWPAFQ@mail.gmail.com> In-Reply-To: <CAK7dMtCtK2HiWQr=cFXwUrP4TxZQD5b_nnNLXyYyk4PANWPAFQ@mail.gmail.com> --ng2XUQsMXIXKkSe6k1YWneraSWUK6f9qD Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 18. 12. 13., Kevin Bowling wrote: > But why, you can trivially see the open() call with truss or more > advanced tracers if you are debugging this Sure. I just followed OpenSSL coding style. Jung-uk Kim > On Thu, Dec 13, 2018 at 6:39 PM Kubilay Kocak <koobs@freebsd.org > <mailto:koobs@freebsd.org>> wrote: >=20 > On 14/12/2018 12:06 pm, Jung-uk Kim wrote: > > Author: jkim > > Date: Fri Dec 14 01:06:34 2018 > > New Revision: 342057 > > URL: https://svnweb.freebsd.org/changeset/base/342057 > > > > Log: > >=C2=A0 =C2=A0 Do not complain when /dev/crypto does not exist. > >=C2=A0 =C2=A0 > >=C2=A0 =C2=A0 Now the new devcrypto engine is enabled since r34200= 9, many > users started > >=C2=A0 =C2=A0 seeing "Could not open /dev/crypto: No such file or > directory".=C2=A0 Disable > >=C2=A0 =C2=A0 the annoying error message as it is not very useful = anyway. > >=C2=A0 =C2=A0 > >=C2=A0 =C2=A0 Note the patch was submitted upstream. > >=C2=A0 =C2=A0 > >=C2=A0 =C2=A0 https://github.com/openssl/openssl/pull/7896 > > > > Modified: > >=C2=A0 =C2=A0 head/crypto/openssl/crypto/engine/eng_devcrypto.c > > > > Modified: head/crypto/openssl/crypto/engine/eng_devcrypto.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/crypto/openssl/crypto/engine/eng_devcrypto.c Fri Dec 14 > 00:40:38 2018=C2=A0 =C2=A0 =C2=A0 =C2=A0 (r342056) > > +++ head/crypto/openssl/crypto/engine/eng_devcrypto.c Fri Dec 14 > 01:06:34 2018=C2=A0 =C2=A0 =C2=A0 =C2=A0 (r342057) > > @@ -24,6 +24,8 @@ > >=C2=A0 =C2=A0 > >=C2=A0 =C2=A0#include "internal/engine.h" > >=C2=A0 =C2=A0 > > +/* #define ENGINE_DEVCRYPTO_DEBUG */ > > + > >=C2=A0 =C2=A0#ifdef CRYPTO_ALGORITHM_MIN > >=C2=A0 =C2=A0# define CHECK_BSD_STYLE_MACROS > >=C2=A0 =C2=A0#endif > > @@ -615,6 +617,9 @@ void engine_load_devcrypto_int() > >=C2=A0 =C2=A0 =C2=A0 =C2=A0ENGINE *e =3D NULL; > >=C2=A0 =C2=A0 > >=C2=A0 =C2=A0 =C2=A0 =C2=A0if ((cfd =3D open("/dev/crypto", O_RDWR= , 0)) < 0) { > > +#ifndef ENGINE_DEVCRYPTO_DEBUG > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (errno !=3D ENOENT) > > +#endif > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fprintf(stderr, "Could no= t open /dev/crypto: %s\n", > strerror(errno)); > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return; > >=C2=A0 =C2=A0 =C2=A0 =C2=A0} >=20 > How trivially could devcrypto_debug=C2=A0 be modified to be a runti= me > configuration (say sysctl) setting? --ng2XUQsMXIXKkSe6k1YWneraSWUK6f9qD-- --1A1U1JfV4cX6yyHCJfcUXDapDfk0wZpCR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlwT9iEACgkQfJ+WJvzb 8UaRCwf/QHaQ/mXYcG/1G9Te4378i4Bw0FX02yXCLyk79oFwr+o/3xsWMZy44Ee+ JLQHc3fd8l+vtGiHEPbjseNESaUTMzxr7AeDHtfg10lvw8JgeERqusrTrjUtz8Ov GryFtSmFcJHcTYIytBfZ/AsAHCVI5tO5f0laaPTZLJaNcKpRLd0N2KqM5aFCdKzG TC9LJwqGPi1CahYQBBLCRtxd9u1ekDnePPanXuDgLI5hqdktMn6oZc1/ZTJMH8Qq lHWo7+vI9RyscBcvIlHMQyWo2uNHSEyj3vQfLMtFTMNdxlJjcvBKul3ETUR5B7bn wIHgW9r43MNUC0ygTpadkY34Tww3Nw== =Ycio -----END PGP SIGNATURE----- --1A1U1JfV4cX6yyHCJfcUXDapDfk0wZpCR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e431b5b8-3a57-5562-b50e-21ed1246df4f>