Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 May 2009 16:41:33 +0000 (UTC)
From:      Rick Macklem <rmacklem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r192588 - head/sys/fs/nfsserver
Message-ID:  <200905221641.n4MGfXX9012380@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rmacklem
Date: Fri May 22 16:41:33 2009
New Revision: 192588
URL: http://svn.freebsd.org/changeset/base/192588

Log:
  Change the reboot panic that would have occurred if clientid
  numbers wrapped around to a printf() warning of a possible
  DOS attack, in the experimental nfsv4 server.
  
  Approved by:	kib (mentor)

Modified:
  head/sys/fs/nfsserver/nfs_nfsdstate.c

Modified: head/sys/fs/nfsserver/nfs_nfsdstate.c
==============================================================================
--- head/sys/fs/nfsserver/nfs_nfsdstate.c	Fri May 22 16:11:00 2009	(r192587)
+++ head/sys/fs/nfsserver/nfs_nfsdstate.c	Fri May 22 16:41:33 2009	(r192588)
@@ -3705,12 +3705,8 @@ nfsrv_nextclientindex(void)
 	if (client_index != 0)
 		return (client_index);
 
-	/*
-	 * In practice we'll never get here, but the panic is here
-	 * just for fun. (client_index will not wrap around on any real server)
-	 */
-	panic("nfsv4 server out of clientids");
-	return (0);	/* Just to shut the compiler up */
+	printf("out of clientids, possible DOS attack\n");
+	return (client_index);
 }
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905221641.n4MGfXX9012380>