Date: Sun, 10 Jan 2021 21:17:48 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Mitchell Horne <mhorne@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: facdd1cd2045 - main - cgem: add 64-bit support Message-ID: <B11437E6-5865-460B-92A0-62D82F2BBEFC@freebsd.org> In-Reply-To: <202101102053.10AKrGqv070360@gitrepo.freebsd.org> References: <202101102053.10AKrGqv070360@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 Jan 2021, at 20:53, Mitchell Horne <mhorne@FreeBSD.org> wrote:
> diff --git a/sys/dev/cadence/if_cgem.c b/sys/dev/cadence/if_cgem.c
> index 3c5277452469..77337e977dcc 100644
> --- a/sys/dev/cadence/if_cgem.c
> +++ b/sys/dev/cadence/if_cgem.c
> @@ -77,6 +77,14 @@ __FBSDID("$FreeBSD$");
> #include <dev/mii/mii.h>
> #include <dev/mii/miivar.h>
>
> +#ifdef EXT_RESOURCES
> +#include <dev/extres/clk/clk.h>
> +#endif
> +
> +#if INTPTR_MAX == INT64_MAX
> +#define CGEM64
> +#endif
This isn't going to work with CHERI. Perhaps a BUS_SPACE_MAXADDR check,
or SIZE_MAX? The former is probably preferable for PAE systems.
Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B11437E6-5865-460B-92A0-62D82F2BBEFC>