Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Aug 2014 17:13:47 +0200
From:      olli hauer <ohauer@gmx.de>
To:        marino@freebsd.org
Cc:        svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Adam Weinberger <adamw@FreeBSD.org>, Adam Weinberger <adamw@adamw.org>
Subject:   Re: svn commit: r365003 - head/devel/elfsh/files
Message-ID:  <53F0C6AB.8070309@gmx.de>
In-Reply-To: <53F0C0BC.2000902@marino.st>
References:  <201408151704.s7FH4f4W071527@svn.freebsd.org> <20140816164551.GA86642@FreeBSD.org> <53EF9469.3070704@gmx.de> <20140817091822.GA51054@FreeBSD.org> <7012BDCA-0949-4A7F-A017-D8F76476F8B9@adamw.org> <53F0C0BC.2000902@marino.st>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-08-17 16:48, John Marino wrote:
> On 8/17/2014 16:29, Adam Weinberger wrote:
>> On 17 Aug, 2014, at 5:18, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
>>
>>> On Sat, Aug 16, 2014 at 07:27:05PM +0200, olli hauer wrote:
>>>> There are 1182 ports with an '_' in the name and I think reading a patch name
>>>> patch-mod_foo__main.c is easier to read then
>>>> patch-mod_foo_main.c
>>>> patch-mod_foo-main.c
>>>> patch-mod_foo--main.c
>>>> patch-mod_foo+main.c
>>>
>>> Apparently there *are* people who don't see the ugliness of __!
>>
>> More than one.
>>
> 
> patch-mod_foo__main.c is too simple.
> Try:
> patch-alpha__bravo__charlie__delta-echo__foxtrot__golf__hotel__india_juliet.cpp
> 
> then 20 more of those in the same directory.  Very ugly.
> 
> eye of the beholder I guess.
> 

No, your example looks pretty to me ;)

At last if I compare your example with '+' or '-' that is also not clash free.

patch-alpha__bravo__charlie__delta-echo__foxtrot__golf__hotel__india_juliet.cpp
patch-alpha+bravo+charlie+delta-echo+foxtrot+golf+hotel+india_juliet.cpp
patch-alpha-bravo-charlie-delta-echo-foxtrot-golf-hotel-india_juliet.cpp

E.g. in devel/psptoolchain-newlib it is not clear without reading the full
patch filename in which path the patch applies.


-- 
olli



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53F0C6AB.8070309>