Date: Tue, 19 Aug 1997 17:39:39 -0500 From: Jonathan Lemon <jlemon@americantv.com> To: Jaye Mathisen <mrcpu@cdsnet.net> Cc: hackers@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: vm86.h compile warning Message-ID: <19970819173939.43163@right.PCS> In-Reply-To: <Pine.NEB.3.95.970819141906.17998E-100000@mail.cdsnet.net>; from Jaye Mathisen on Aug 08, 1997 at 02:20:28PM -0700 References: <Pine.NEB.3.95.970819141906.17998E-100000@mail.cdsnet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Aug 08, 1997 at 02:20:28PM -0700, Jaye Mathisen wrote: > > I have no idea if this warning is apropos to this header file or not, and > I wouldn't deign to guess at it's correctness. > > I just point it out because I don't like warnings that tell me I'm > probably not getting what I bargained for. :) > > Build of skill-3.7.4 on -current: > > ===> Configuring for skill-3.7.4 > Configuring as bsd44: OSTYPE=bsd-44 COPTS= LIBS=-lkvm > ===> Building for skill-3.7.4 > cc -O -c main.c > cc -O -c argparse.c > rm -f getproc.c getproc.o > ln -s machdep/bsd-44.c getproc.c > cc -O -c getproc.c > In file included from /usr/include/machine/pcb_ext.h:36, > from /usr/include/machine/pcb.h:48, > from /usr/include/sys/user.h:40, > from getproc.c:22: > /usr/include/machine/vm86.h:109: warning: `struct proc' declared inside > parameter list > /usr/include/machine/vm86.h:109: warning: its scope is only this > definition or declaration, > /usr/include/machine/vm86.h:109: warning: which is probably not what you > want. > cc -O main.o argparse.o getproc.o -o skill -lkvm Ugh. <machine/vm86.h> declares a function that takes a (struct proc *) as a parameter, but you haven't included <sys/proc.h> beforehand, so thus this error. I see that <sys/user.h> does pull in proc.h, but too late. I'm not sure what the best way to fix this is; #ifdef KERNEL around the parameter declarations in vm86.h? -- Jonathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19970819173939.43163>