Date: Sun, 10 Dec 1995 15:31:45 +0100 (MET) From: J Wunsch <j@uriah.heep.sax.de> To: peter@jhome.DIALix.COM (Peter Wemm) Cc: bde@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/net if_tun.c Message-ID: <199512101431.PAA06047@uriah.heep.sax.de> In-Reply-To: <Pine.BSF.3.91.951210133345.6047C-100000@jhome.DIALix.COM> from "Peter Wemm" at Dec 10, 95 01:37:10 pm
next in thread | previous in thread | raw e-mail | index | archive | help
As Peter Wemm wrote: > > > Removed an `#ifdef __FreeBSD__'. Hundreds, if not thousands of other > > FreeBSD-specific things aren't ifdefed. > > I think our source could stand a lot more cleanup in this way.. After > all, our sources are for FreeBSD, not GenericBSD or PortableBSD... > > Especially so, since we've not been consistant. I think the only real > place where this kind of thing needs to stay is where we've taken 3rd > party device drivers into our source that we dont maintain ourselves, and > have cross-machine and version portability built in (if_cx and cx.c for > example). pcvt, too. Please, don't remove the #if PCVT_FREEBSD stuff there. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199512101431.PAA06047>