Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Nov 2007 07:21:22 +0100
From:      Max Laier <max@love2party.net>
To:        Doug Barton <dougb@freebsd.org>
Cc:        cvs-src@freebsd.org, Max Laier <mlaier@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/share/examples/pf Makefile ackpri faq-example1 faq-example2 faq-example3 pf.conf queue1 queue2 queue3 queue4 spamd src/etc Makefile pf.conf
Message-ID:  <200711110721.33559.max@love2party.net>
In-Reply-To: <alpine.BSF.0.99999.0711102200040.15336@qbhto.arg>
References:  <200711110116.lAB1GqRr030079@repoman.freebsd.org> <alpine.BSF.0.99999.0711102200040.15336@qbhto.arg>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
On Sunday 11 November 2007, Doug Barton wrote:
> On Sun, 11 Nov 2007, Max Laier wrote:
> > mlaier      2007-11-11 01:16:52 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    share/examples/pf    Makefile ackpri faq-example1 faq-example2
> >                         faq-example3 queue1 queue2 queue3 queue4
> >                         spamd
> >    etc                  Makefile
> >  Added files:
> >    share/examples/pf    pf.conf
> >  Removed files:
> >    etc                  pf.conf
> >  Log:
> >  Update pf examples from OpenBSD to catch up with new stateful
> > defaults and other syntax changes.  Move pf.conf from /etc to
> > examples, too.
>
> In regards to the last bit, it seems to me that moving pf.conf (which I
> agree is a good idea) should be a repo-copy, not a delete/add. I also
> think that this change requires an update to pf.conf.5, and
> ObsoleteFiles.inc.

I didn't do a repo-copy as there is really no history to preserve.  As for 
the pf.conf.5 changes - what do you have in mind?  I don't see what 
should be changed.  /etc/pf.conf is still the default location for the 
ruleset (as set by defaults/rc.conf) and there is already a pointer to 
the examples.  ObsoleteFiles.inc doesn't make sense at all, as there 
should be an /etc/pf.conf.  The whole point of this is that you can have 
your own ruleset and not have it overwritten every time you run 
mergemaster.  In contrast to other default settings we install in /etc 
the pf.conf example doesn't have any function as is - thus the desire for 
human interaction which is the point of this commit.

> If any of this has been done already and I missed it, I apologize for
> the noise.

-- 
/"\  Best regards,                      | mlaier@freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier@EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQBHNp9tXyyEoT62BG0RAjg4AJ4jMwWj7iX1O4+TKZRt3at9yASmQwCfZ7sG
KeP1EF5sreV6VXdsM2t7QCM=
=aX2w
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200711110721.33559.max>