Date: Thu, 28 Aug 1997 07:19:15 -0400 (EDT) From: David Holland <dholland@eecs.harvard.edu> To: freebsd-security@freebsd.org Subject: sleeps in inetd... Message-ID: <199708281119.HAA12959@burgundy.eecs.harvard.edu>
next in thread | raw e-mail | index | archive | help
It appears that guy was right about one thing. This bug affects Linux,
OpenBSD, and NetBSD as well as FreeBSD, all in -current.
Several people have looked right through this recently, including
me. :(
The KNF style guide should really be revised to prohibit, instead of
require, constructions of the form
if (a)
b();
Sigh.
--- inetd.c.old Thu Aug 28 07:06:31 1997
+++ inetd.c Thu Aug 28 07:10:34 1997
@@ -386,11 +386,12 @@
}
readable = allsock;
if ((n = select(maxsock + 1, &readable, (fd_set *)0,
(fd_set *)0, (struct timeval *)0)) <= 0) {
- if (n < 0 && errno != EINTR)
+ if (n < 0 && errno != EINTR) {
syslog(LOG_WARNING, "select: %m");
- sleep(1);
+ sleep(1);
+ }
continue;
}
for (sep = servtab; n && sep; sep = sep->se_next)
if (sep->se_fd != -1 && FD_ISSET(sep->se_fd, &readable)) {
--
- David A. Holland | VINO project home page:
dholland@eecs.harvard.edu | http://www.eecs.harvard.edu/vino
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199708281119.HAA12959>