Date: Thu, 9 Jan 2014 12:12:46 +0100 From: Antoine Brodin <antoine@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r338284 - head/comms/gnocky Message-ID: <CAALwa8meEZ6GYMpMb1NvQCNk3k2Cp7=7rhn7g7xsftHW3Z82SA@mail.gmail.com> In-Reply-To: <20140109110311.GA46469@FreeBSD.org> References: <201312311227.rBVCRwfe081248@svn.freebsd.org> <20140109110311.GA46469@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 9, 2014 at 12:03 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Dec 31, 2013 at 12:27:58PM +0000, Antoine Brodin wrote: >> New Revision: 338284 >> URL: http://svnweb.freebsd.org/changeset/ports/338284 >> >> -.if ${PORT_OPTIONS:MNLS} >> -USES+= gettext >> -PLIST_SUB+= NLS="" >> -.else >> -CONFIGURE_ARGS+= --disable-nls >> -PLIST_SUB+= NLS="@comment " >> -.endif >> +OPTIONS_SUB= yes >> +NLS_USES= gettext >> +NLS_CONFIGURE_ENABLE= nls > > Why not just NLS_CONFIGURE_OFF= --disable-nls? It looks like NLS support is > on by default, and NLS_CONFIGURE_OFF saves passing explicit --enable-nls to > the args (thus making them shorter). Hello, NLS_CONFIGURE_ENABLE=nls is 7 characters less than NLS_CONFIGURE_OFF=--disable-nls So it makes the Makefile shorter. Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8meEZ6GYMpMb1NvQCNk3k2Cp7=7rhn7g7xsftHW3Z82SA>