Date: Sun, 16 Sep 2012 13:26:47 -0500 From: Stephen Montgomery-Smith <stephen@missouri.edu> To: Bruce Evans <brde@optusnet.com.au> Cc: freebsd-numerics@FreeBSD.org Subject: Re: Complex arg-trig functions Message-ID: <505619E7.8080804@missouri.edu> In-Reply-To: <20120917025148.X2943@besplex.bde.org> References: <5017111E.6060003@missouri.edu> <20120814201105.T934@besplex.bde.org> <502A780B.2010106@missouri.edu> <20120815223631.N1751@besplex.bde.org> <502C0CF8.8040003@missouri.edu> <20120906221028.O1542@besplex.bde.org> <5048D00B.8010401@missouri.edu> <504D3CCD.2050006@missouri.edu> <504FF726.9060001@missouri.edu> <20120912191556.F1078@besplex.bde.org> <20120912225847.J1771@besplex.bde.org> <50511B40.3070009@missouri.edu> <20120913204808.T1964@besplex.bde.org> <5051F59C.6000603@missouri.edu> <20120914014208.I2862@besplex.bde.org> <50526050.2070303@missouri.edu> <20120914212403.H1983@besplex.bde.org> <50538E28.6050400@missouri.edu> <20120915231032.C2669@besplex.bde.org> <50548E15.3010405@missouri.edu> <5054C027.2040008@missouri.edu> <5054C200.7090307@missouri.edu> <20120916041132.D6344@besplex.bde.org> <50553424.2080902@missouri.edu> <20120916134730.Y957@besplex.bde.org> <5055ECA8.2080008@missouri.edu> <5055EE33.2090400@missouri.edu> <20120917025148.X2943@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/16/2012 12:12 PM, Bruce Evans wrote: > On Sun, 16 Sep 2012, Stephen Montgomery-Smith wrote: > >> A style question: do you mind this >> >> if (sy==0) ry = copysign(ry, -1); >> if (A < 1) A = 1; >> >> or do you prefer >> >> if (sy==0) >> ry = copysign(ry, -1); >> if (A < 1) >> A = 1; > > Multiple statements per line are large style bugs, as are missing spaces > around == operators (I might agree only to omitting spaces around most > multiplication operators and some addition operators). > > Apart from being less readable, multiple statements per line break > debugging > using line-based debuggers. > > BTW, copysign() is builtin in gcc-4.2 and not broken by a macro in > <math.h>. > Otherwise it would be very slow. I changed it to: if (sy==0) ry = -ry; I happen to know that ry is always positive.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?505619E7.8080804>