Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 01 May 2009 10:58:03 -0700
From:      Julian Elischer <julian@elischer.org>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        sobomax@freebsd.org, freebsd-hackers@freebsd.org, rdivacky@freebsd.org, ed@freebsd.org, marius@alchemy.franken.de, christoph.mallon@gmx.de
Subject:   Re: C99: Suggestions for style(9)
Message-ID:  <49FB382B.6030406@elischer.org>
In-Reply-To: <20090501.082020.698246310.imp@bsdimp.com>
References:  <49F4070C.2000108@gmx.de>	<20090501112239.GA23199@alchemy.franken.de>	<49FADEF3.5010106@gmx.de> <20090501.082020.698246310.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
M. Warner Losh wrote:

[...]
(about return ();)

> 
> It has been an example used for the past 15 years at least as to why
> to do this...  I don't know how many people have actually used the
> ability to do this in code.

I have done so..

> 
> : Also I consider this as gross abuse: Macro names shall be in all 
> : uppercase, so it is clear that there is a macro at work. Therefore 
> : "return" is not a candidate. So this would violate yet another rule in 
> : style(9) (the original return already violates the no-redundant 
> : parentheses rule).
> : Also I would not mention __func__: there were objections against using 
> : it in the past (though I, logically, prefer its use).
> 
> It is a debugging aid, but one of dubious value for a far more
> fundamental reason:
> 
> 	    return;
> 
> will break any macro.
> 
> Warner
> _______________________________________________
> freebsd-hackers@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49FB382B.6030406>