Date: Sun, 5 Nov 2017 11:45:38 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Ngie Cooper <ngie@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325443 - in head: . lib/libclang_rt share/mk Message-ID: <44947619-4DC5-4F5E-B26C-4F29917F9DE3@gmail.com> In-Reply-To: <201711051938.vA5Jcpnc033399@repo.freebsd.org> References: <201711051938.vA5Jcpnc033399@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Nov 5, 2017, at 11:38, Ngie Cooper <ngie@FreeBSD.org> wrote: > > Author: ngie > Date: Sun Nov 5 19:38:51 2017 > New Revision: 325443 > URL: https://svnweb.freebsd.org/changeset/base/325443 > > Log: > Fix paths for cross-built versions of lib/libclang_rt and hardfloat arm variants > > - Define TARGET_CPUARCH and use in libclang_rt as the basis for CRTARCH > > When cross-compiling, the wrong architecture was being embedded in the > libclang_rt binary filenames. It should be based on TARGET_ARCH (target), not > MACHINE_ARCH (host). > > If TARGET_ARCH isn't defined (host-builds), fallback to MACHINE_ARCH. > > - Define CRTARCH to armhf when TARGET/TARGET_ARCH are set to arm/armv[67] > > TARGET_ABI/TARGET_CPU in Makefile.inc1 sets the ABI to gnueabihf, which > affects the clang lookup path per `getArchNameForCompilerRTLib(..)` in > contrib/llvm/tools/clang/lib/Driver/ToolChain.cpp, so chase clang and > Linux's assumed naming convention for hard-float arm architectures. > > CROSSENV (in Makefile.inc1) sets CPUTYPE/MACHINE(_ARCH)? to the > TARGET*-relevant values when building the `libraries` target, so test > those variables instead. > > - Add OLD_FILES/OLD_LIBS entries for TARGET/TARGET_ARCH == arm/armv[67]. This > impacts only arm/armv6 and arm/armv7. > > PR: 222925 MFC after: 2 weeks [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE5bk3FaGcY5rvqmb79YOpJmkwhhUFAln/amMACgkQ9YOpJmkw hhXysQ//YoRV+3WKtmKz0wWVGSk2D+v/gLB7EIQCuZKdVDpjdJ/QAU1r+cmJvF58 WFkScrjeVlwFqOz2DB2K+2g3NBYtgkcRQOmQzgw/cclANNxiTOb2NTHOnYlvnzzP hzotwUDNTtRq/1t76Pk29WWU1Dd+mH8FnSOBgmTIeEy3b8RnE6T6OJcMNx/NEzc0 2rK7OH6r450HBsNz5bktv7FT4aXJj2sDTCQUWjLw69zXFHX0LZHAczrkJjoIHB1Z HLQ8Gzzbd3OJaRK+7GyBAZQXjzxY2F96SupakLo56284tf9S8Ccr97XUDlhu+GTa GffH8djt7VfgMm+kZnuZG2+eGJqQ3LuDgIpYYIM39zgZd6+grNlyOgfCAQ4Ww0kP Ydz2qaUzX8DFD21U2bp6uEEK8vWVEYlYPt01vLaM6iGn0ICSra2XmaJT6m24/UZj tbf+5E99PF1dy7xWajWlJiEYgpvXxkUsQB7thKyEdvaJoVZc98rDb6vF0g/Kvg+K a48nvCk9mAaPPZ/ZJ8revBkQeBV1cbl6tTpMAQnp6VyPyrbqR3I22cssjMKSpdkX belhZh4KJZmxfNe8dcgxJEX4V4XqdS8Wp/BZg4sK0j282wuJKb8xFtplM/9bvGE0 4vWIfkvZGoqxMo/5FxcdQLnEgD2tKVKj+/i+EUTIcIFtKWjtD9U= =gWW1 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44947619-4DC5-4F5E-B26C-4F29917F9DE3>