Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Oct 1997 00:20:58 +0100
From:      Brian Somers <brian@awfulhak.org>
To:        =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru>
Cc:        Brian Somers <brian@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.sbin/ppp chat.c command.c defs.h main.c modem.c timer.c 
Message-ID:  <199710242320.AAA25601@awfulhak.demon.co.uk>
In-Reply-To: Your message of "Sat, 25 Oct 1997 03:06:20 %2B0400." <Pine.BSF.3.96.971025030449.10241A-100000@lsd.relcom.eu.net> 

next in thread | previous in thread | raw e-mail | index | archive | help

> On Fri, 24 Oct 1997, Brian Somers wrote:
> 
> > brian       1997/10/24 15:36:34 PDT
> > 
> >   Modified files:
> >     usr.sbin/ppp         chat.c command.c defs.h main.c modem.c 
> >                          timer.c 
> >   Log:
> >   sleep => nointr_sleep
> >   usleep => nointr_usleep
> >   (not just a #define)
> 
> I already think about this way... Someone can add new sleep()s into code
> not thinking that it can be interrupted, so I decide to do #define.

This works both ways though - with the #define we're obscuring the 
fact that it's not the *real* [u]sleep().

I considered having a #define sleep DontUseSleep, but then 
retrospectively thought that people should really test their changes 
(and figure out that sleep is a no-no).

> -- 
> Andrey A. Chernov
> <ache@nietzsche.net>
> http://www.nagual.pp.ru/~ache/
> 

-- 
Brian <brian@Awfulhak.org>, <brian@FreeBSD.org>, <bri@OpenBSD.org>
      <http://www.Awfulhak.org>;
Don't _EVER_ lose your sense of humour....





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199710242320.AAA25601>