Date: Wed, 4 Jan 2017 22:45:46 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310889 - head/tools/build/mk Message-ID: <EC01EF9C-8E57-4CC0-BF91-3F4B010D7FCA@FreeBSD.org> In-Reply-To: <201612310607.uBV67mVO019147@repo.freebsd.org> References: <201612310607.uBV67mVO019147@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 31 Dec 2016, at 07:07, Jung-uk Kim <jkim@FreeBSD.org> wrote: > > Author: jkim > Date: Sat Dec 31 06:07:48 2016 > New Revision: 310889 > URL: https://svnweb.freebsd.org/changeset/base/310889 > > Log: > Do not remove llvm-objdump. It is installed by default since r310840. > > Modified: > head/tools/build/mk/OptionalObsoleteFiles.inc > > Modified: head/tools/build/mk/OptionalObsoleteFiles.inc > ============================================================================== > --- head/tools/build/mk/OptionalObsoleteFiles.inc Sat Dec 31 03:07:48 2016 (r310888) > +++ head/tools/build/mk/OptionalObsoleteFiles.inc Sat Dec 31 06:07:48 2016 (r310889) > @@ -1484,7 +1484,6 @@ OLD_FILES+=usr/bin/llvm-link > OLD_FILES+=usr/bin/llvm-lto > OLD_FILES+=usr/bin/llvm-mc > OLD_FILES+=usr/bin/llvm-nm > -OLD_FILES+=usr/bin/llvm-objdump > OLD_FILES+=usr/bin/llvm-pdbdump > OLD_FILES+=usr/bin/llvm-rtdyld > OLD_FILES+=usr/bin/llvm-symbolizer This block is under MK_CLANG_EXTRAS. Shouldn't llvm-objdump be moved to the MK_CLANG block just above instead? Otherwise it would never be cleaned up, if somebody disabled llvm/clang completely. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlhtbQ8ACgkQsF6jCi4glqOX/wCg/xD3xzlHp2MoLgz4xRBnpG6i SBMAniJMa1gmVN20FuK95RW25Pm6e2sO =vRhu -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EC01EF9C-8E57-4CC0-BF91-3F4B010D7FCA>