Date: Sun, 15 Jul 2012 22:04:22 +0200 From: Lars Engels <lars.engels@0x20.net> To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= <des@des.no> Cc: "Justin T. Gibbs" <gibbs@FreeBSD.org>, current@FreeBSD.org Subject: Re: PAM passwdqc, strict aliasing, and WARNS Message-ID: <20120715200422.GZ90853@e-new.0x20.net> In-Reply-To: <86obnif10y.fsf@ds4.des.no> References: <F7FA2B4D-BD56-4EC4-9D93-B5AA847063D7@FreeBSD.org> <86obnif10y.fsf@ds4.des.no>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Jul 15, 2012 at 12:09:17AM +0200, Dag-Erling Smørgrav wrote: > "Justin T. Gibbs" <gibbs@FreeBSD.org> writes: > > Someone who has yet to confess added -Werror to the global CFLAGS > > (via /etc/make.conf) for one of our systems at work. Before I > > figured out that this was the cause of builds failing, I hacked up > > pam_passwdc to resolve the problem. This gets the module to > > WARNS=2, but to go farther, the "logically const" issues with this > > code will need to be sorted out. > > > > Is this change worth committing? Is this the best way to resolve > > the strict aliasing issues in this code? > > I really don't like that sort of game. If you look at other PAM > consumer code, you'll see that the common idiom is what Jilles > suggested, i.e. use a temporary variable of the appropriate type. > > That being said, pam_passwdqc should probably be either updated or > removed. The version we have is ten years old. But it still works... [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlADIkYACgkQKc512sD3afiC/gCfWZcu6Dfr8X1VKUFYUc5/7hKf 5dAAoK05ROMSoqFUnOvPhetqtlocTCTa =lp0f -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120715200422.GZ90853>