Date: Tue, 27 Aug 2013 16:27:19 +0200 From: Michael Tuexen <tuexen@freebsd.org> To: Andre Oppermann <andre@freebsd.org> Cc: freebsd-arm <freebsd-arm@FreeBSD.org> Subject: Re: ARM network trouble after recent mbuf changes Message-ID: <0833E93A-BD62-4312-88D6-61E60CE6BCF6@freebsd.org> In-Reply-To: <521CB66B.9020806@freebsd.org> References: <1377550636.1111.156.camel@revolution.hippie.lan> <521BC472.7040804@freebsd.org> <521BD531.4090104@sbcglobal.net> <521C4CD9.4050308@freebsd.org> <0E0536B2-2B7F-4EED-9EFD-4B9E2C2D729A@freebsd.org> <521C87FF.8010100@freebsd.org> <D2FB4EEE-DE17-43CB-9E77-7BCA7D1B9661@freebsd.org> <521CB66B.9020806@freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Aug 27, 2013, at 4:23 PM, Andre Oppermann <andre@freebsd.org> wrote: > On 27.08.2013 15:29, Michael Tuexen wrote: >> On Aug 27, 2013, at 1:05 PM, Andre Oppermann <andre@FreeBSD.org> wrote: >>> Thanks. I've changed the test accordingly. >>> >>> While doing the CTASSERTs to prevent such an incident in the future I stumbled >>> across a bit of evil name space pollution in mbuf.h. It is impossible to take >>> sizeof(struct m_ext) because "m_ext" is redefined to point into struct mbuf. >>> >>> In addition to the alignment fix I've solved the namespace issues with m_ext >>> and the stupidly named struct pkthdr as well and properly prefixed them. The >>> fallout from LINT was zero (as it should be). >>> >>> http://people.freebsd.org/~andre/m_hdr-alignment-20130827.diff >>> >>> Please test. > > >> Done. r254954 with your patch applied runs fine on a RPi. > > Does the CTASSERT trigger if the padding in m_hdr is not there? Testing... Best regards Michael > > -- > Andre > >home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0833E93A-BD62-4312-88D6-61E60CE6BCF6>