Date: Tue, 17 May 2011 00:19:54 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Poul-Henning Kamp <phk@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221993 - in head/sys: kern sys Message-ID: <20110516211954.GJ48734@deviant.kiev.zoral.com.ua> In-Reply-To: <201105161618.p4GGIeDd089851@svn.freebsd.org> References: <201105161618.p4GGIeDd089851@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--caqKA7PbDQ8UCDMt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 16, 2011 at 04:18:40PM +0000, Poul-Henning Kamp wrote: > Author: phk > Date: Mon May 16 16:18:40 2011 > New Revision: 221993 > URL: http://svn.freebsd.org/changeset/base/221993 >=20 > Log: > Change the length quantities of sbufs to be ssize_t rather than int. > =20 > Constify a couple of arguments. > Modified: head/sys/sys/sbuf.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/sys/sbuf.h Mon May 16 15:59:50 2011 (r221992) > +++ head/sys/sys/sbuf.h Mon May 16 16:18:40 2011 (r221993) > @@ -44,8 +44,8 @@ struct sbuf { > sbuf_drain_func *s_drain_func; /* drain function */ > void *s_drain_arg; /* user-supplied drain argument */ > int s_error; /* current error code */ > - int s_size; /* size of storage buffer */ > - int s_len; /* current length of string */ > + ssize_t s_size; /* size of storage buffer */ > + ssize_t s_len; /* current length of string */ struct sbuf is exposed to the libsubf.so consumers. I think that libsbuf.so version shall be bumped (since no symver compat can be provided, due to lack of versioning for libsbuf). The bump was also needed after the r212367. Lets do one for two changes. --caqKA7PbDQ8UCDMt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk3RlPoACgkQC3+MBN1Mb4iIBgCeJSB3gUmIawqR1JVgD4NUsnN4 elAAn08V8lylLUlcopYiAcR59LuMn/5U =viEz -----END PGP SIGNATURE----- --caqKA7PbDQ8UCDMt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110516211954.GJ48734>