Date: Sun, 1 Mar 2009 11:05:57 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Peter Wemm <peter@wemm.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186057 - head/sys/netinet Message-ID: <20090301101142.V96785@maildrop.int.zabbadoz.net> In-Reply-To: <e7db6d980812162012w1f98f3f9kc4383823a5b62482@mail.gmail.com> References: <200812132159.mBDLxIQv040799@svn.freebsd.org> <e7db6d980812162012w1f98f3f9kc4383823a5b62482@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 16 Dec 2008, Peter Wemm wrote:
> On Sat, Dec 13, 2008 at 1:59 PM, Bjoern A. Zeeb <bz@freebsd.org> wrote:
>> De-virtualize the MD5 context for TCP initial seq number generation
>> and make it a function local variable like we do almost everywhere
>> inside the kernel.
> [..]
>> --- head/sys/netinet/vinet.h Sat Dec 13 21:17:46 2008 (r186056)
>> +++ head/sys/netinet/vinet.h Sat Dec 13 21:59:18 2008 (r186057)
>> @@ -142,7 +142,6 @@ struct vnet_inet {
...
> I'm bitterly unhappy with this. Every time these structs are touched,
> either directly or indirectly, there is a guaranteed ABI breakage with
> kernel modules.
>
> There needs to be a __FreeBSD_version bump (or something similar)
> every time any of these structures change, and any kernel modules
> *must* be prevented from loading. It can't be a >= some version, it
> has to be an exact match.
...
> In the mean time, I'd like to see some compile-time asserts in there
> to make sure there are no accidental size changes of this structure.
This has finally happened, thanks to Juli Mallett now finding a good
CTASSERT-a-like way that also prints the expected and the actual size.
Without that I had found it was impossible to get the proper values
for all architectures we support to be able to (cross) build or finish
a universe when trying to implement this end of last year.
/bz
--
Bjoern A. Zeeb The greatest risk is not taking one.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090301101142.V96785>