Date: Mon, 19 Nov 2007 09:02:33 +0100 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk> To: Ulf Lilleengen <lulf@stud.ntnu.no> Cc: freebsd-current@FreeBSD.ORG, freebsd-hackers@FreeBSD.ORG, "Matthew D. Fuller" <fullermd@over-yonder.net>, Thierry Herbelot <thierry@herbelot.com>, Alexander Sabourenkov <screwdriver@lxnt.info>, sos@FreeBSD.ORG Subject: Re: Patch RFC: Promise SATA300 TX4 hardware bug workaround. Message-ID: <47414319.6070303@deepcore.dk> In-Reply-To: <473DBABE.3070901@deepcore.dk> References: <472A548B.50406@lxnt.info> <20071116144304.GA7950@stud.ntnu.no> <473DBABE.3070901@deepcore.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------090105030601040509090901
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Hi All!
I'd like to get the final verdict of the attached patch and if it fixes=20
the problem or not.
Please test and report, its a bit urgent if it need to get into R7 :)
-S=F8ren
--------------090105030601040509090901
Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0";
name="promise-fix3"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="promise-fix3"
? promise-fix2
? promise-fix3
Index: ata-chipset.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-chipset.c,v
retrieving revision 1.202.2.2
diff -u -r1.202.2.2 ata-chipset.c
--- ata-chipset.c 31 Oct 2007 19:59:53 -0000 1.202.2.2
+++ ata-chipset.c 18 Nov 2007 11:54:59 -0000
@@ -142,6 +142,7 @@
static int ata_promise_mio_command(struct ata_request *request);
static void ata_promise_mio_reset(device_t dev);
static void ata_promise_mio_dmainit(device_t dev);
+static void ata_promise_mio_setprd(void *xsc, bus_dma_segment_t *segs, int nsegs, int error);
static void ata_promise_mio_setmode(device_t dev, int mode);
static void ata_promise_sx4_intr(void *data);
static int ata_promise_sx4_command(struct ata_request *request);
@@ -792,6 +793,7 @@
prd[i].dbc = htole32((segs[i].ds_len - 1) & ATA_AHCI_PRD_MASK);
}
}
+ KASSERT(nsegs <= ATA_DMA_ENTRIES, "too many DMA segment entries\n");
args->nsegs = nsegs;
}
@@ -2760,6 +2762,8 @@
prd[i].addrhi = htole32((u_int64_t)segs[i].ds_addr >> 32);
}
prd[i - 1].count |= htole32(ATA_DMA_EOT);
+ KASSERT(nsegs <= ATA_DMA_ENTRIES, "too many DMA segment entries\n");
+ args->nsegs = nsegs;
}
static void
@@ -3288,9 +3292,13 @@
/* prime fake interrupt register */
ATA_OUTL(ctlr->r_res2, fake_reg, 0xffffffff);
- /* clear SATA status */
+ /* clear SATA status and unmask interrupts */
ATA_OUTL(ctlr->r_res2, stat_reg, 0x000000ff);
+ /* enable "long burst lenght" on gen2 chips */
+ if ((ctlr->chip->cfg2 == PRSATA2) || (ctlr->chip->cfg2 == PRCMBO2))
+ ATA_OUTL(ctlr->r_res2, 0x44, ATA_INL(ctlr->r_res2, 0x44) | 0x2000);
+
ctlr->allocate = ata_promise_mio_allocate;
ctlr->reset = ata_promise_mio_reset;
ctlr->dmainit = ata_promise_mio_dmainit;
@@ -3778,8 +3786,42 @@
static void
ata_promise_mio_dmainit(device_t dev)
{
+ struct ata_channel *ch = device_get_softc(dev);
+
/* note start and stop are not used here */
ata_dmainit(dev);
+ if (ch->dma)
+ ch->dma->setprd = ata_promise_mio_setprd;
+}
+
+
+#define MAXLASTSGSIZE (32 * sizeof(u_int32_t))
+static void
+ata_promise_mio_setprd(void *xsc, bus_dma_segment_t *segs, int nsegs, int error)
+{
+ struct ata_dmasetprd_args *args = xsc;
+ struct ata_dma_prdentry *prd = args->dmatab;
+ int i;
+
+ if ((args->error = error))
+ return;
+
+ for (i = 0; i < nsegs; i++) {
+ prd[i].addr = htole32(segs[i].ds_addr);
+ prd[i].count = htole32(segs[i].ds_len);
+ }
+ if (segs[i - 1].ds_len > MAXLASTSGSIZE) {
+ //printf("split last SG element of %u\n", segs[i - 1].ds_len);
+ prd[i - 1].count = htole32(segs[i - 1].ds_len - MAXLASTSGSIZE);
+ prd[i].count = htole32(MAXLASTSGSIZE);
+ prd[i].addr = htole32(segs[i - 1].ds_addr +
+ (segs[i - 1].ds_len - MAXLASTSGSIZE));
+ nsegs++;
+ i++;
+ }
+ prd[i - 1].count |= htole32(ATA_DMA_EOT);
+ KASSERT(nsegs <= ATA_DMA_ENTRIES, "too many DMA segment entries\n");
+ args->nsegs = nsegs;
}
static void
@@ -4849,6 +4891,8 @@
prd[i].count = htole32(segs[i].ds_len);
}
prd[i - 1].control = htole32(ATA_DMA_EOT);
+ KASSERT(nsegs <= ATA_DMA_ENTRIES, "too many DMA segment entries\n");
+ args->nsegs = nsegs;
}
static void
Index: ata-dma.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-dma.c,v
retrieving revision 1.147
diff -u -r1.147 ata-dma.c
--- ata-dma.c 8 Apr 2007 21:53:52 -0000 1.147
+++ ata-dma.c 18 Nov 2007 11:54:59 -0000
@@ -213,6 +213,7 @@
prd[i].count = htole32(segs[i].ds_len);
}
prd[i - 1].count |= htole32(ATA_DMA_EOT);
+ KASSERT(nsegs <= ATA_DMA_ENTRIES, "too many DMA segment entries\n");
args->nsegs = nsegs;
}
--------------090105030601040509090901
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
--------------090105030601040509090901--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47414319.6070303>