Date: Sun, 7 Sep 2008 01:54:47 GMT
From: Adam Weinberger <adamw@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Subject: ports/127165: Allow ${TAR} to be overridden in ghostscript8
Message-ID: <200809070154.m871sla7015894@freefall.freebsd.org>
Resent-Message-ID: <200809070200.m872071l016092@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 127165
>Category: ports
>Synopsis: Allow ${TAR} to be overridden in ghostscript8
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 07 02:00:07 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Adam Weinberger
>Release: FreeBSD 7.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 7.0-STABLE FreeBSD 7.0-STABLE #34: Sat Apr 12 11:52:18 UTC 2008 simon@freefall.freebsd.org:/usr/src/sys/i386/compile/FREEFALL i386
>Description:
If you've overridden ${TAR} (say, to add other options), the invocation
in the port Makefile has to be ${TAR} -options. If the Makefile uses
${TAR} options (i.e., no hyphen), tar freaks out.
Attached patch simply adds hyphens before the options, and allows ${TAR}
to be overridden in, for example, /etc/make.conf.
>How-To-Repeat:
>Fix:
It's been a very long time since I've sent a PR. If I'm putting the patch
in wrong, I apologize in advance.
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/print/ghostscript8/Makefile,v
retrieving revision 1.174
diff -u -r1.174 Makefile
--- Makefile 25 Jul 2008 12:24:08 -0000 1.174
+++ Makefile 7 Sep 2008 01:50:08 -0000
@@ -250,8 +250,8 @@
${INSTALL_DATA} ${WRKSRC}/contrib/japanese/doc/* ${WRKSRC}/contrib/japanese
${MKDIR} ${DOCSDIR}
cd ${WRKSRC}/contrib && \
- ${TAR} cf - ${PORTDOC_FILES} | \
- ( cd ${DOCSDIR} && ${TAR} xof - )
+ ${TAR} -cf - ${PORTDOC_FILES} | \
+ ( cd ${DOCSDIR} && ${TAR} -xof - )
.if defined(WITH_FT_BRIDGE)
post-install-fapi:
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809070154.m871sla7015894>