Date: Sat, 21 Aug 2010 21:50:52 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: jhell <jhell@DataIX.net> Cc: FreeBSD Stable <freebsd-stable@freebsd.org> Subject: Re: daily run output 800.scrub-zfs fixups Message-ID: <20100821215052.000030f1@unknown> In-Reply-To: <4C6F5344.6040808@DataIX.net> References: <4C6F5344.6040808@DataIX.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 21 Aug 2010 00:17:08 -0400 jhell <jhell@DataIX.net> wrote:
>
> Hi Alexander,
>
> Attached is a fix for one problem and one slight overlook for
> 800.scrub-zfs.
>
> The first & second change was probably just an oversight but none the
> less they both give a false impression of actions taken.
>
> Change1:
> ${daily_scrub_zfs_default_threshold=30} is missng the ':'
> which would ultimately reset the users supplied value in
> periodic.conf to 30.
I will have a look at this.
> Change2:
> ${_scrub_diff} -le ${_pool_threshold} would cause the scrub
> to be run on the day after the threshold was met. So I changed '-le'
> -> '-lt' which causes it to be run on the 30th day instead of the
> 31st day.
This depends how you define threshold... I had number of days between
scrubs in my mind. Now it depends what I wrote in the man page, if it
tells what I had in mind (I don't remember, I have to look at it
myself, but I'm not a native english speaker, so I may have not wrote
it good enough).
This is not set in stone, if the majority of people want something
else, I'm surely not in the way.
Bye,
Alexander.
> -------- Original Message --------
> Subject: xxxxxx.dataix.local daily run output
> Date: Fri, 20 Aug 2010 03:18:09 -0400 (EDT)
> From: Superuser Root <root@xxxxxx.dataix.local>
> To: root@xxxxxx.dataix.local
>
> ...snip...
>
> Scrubbing of zfs pools:
> skipping scrubbing of pool 'exports':
> last scrubbing is 30 days ago, threshold is set to 30 days
>
> -- End of daily output --
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100821215052.000030f1>