Date: Tue, 16 May 2000 10:20:01 -0700 (PDT) From: Bosko Milekic <bmilekic@dsuper.net> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/18471: Checking freeing of mbufs. Message-ID: <200005161720.KAA20390@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/18471; it has been noted by GNATS. From: Bosko Milekic <bmilekic@dsuper.net> To: dwmalone@maths.tcd.ie Cc: jin@george.lbl.gov, FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: kern/18471: Checking freeing of mbufs. Date: Tue, 16 May 2000 13:15:03 -0400 (EDT) Indeed, David is correct when he argues that this should be a panic, especially since it's a KASSERT(). Without even considering the other troubles the [now confused] calling code will run into, just look at what actually happens at the mcluster free routine: the "freed" cluster is attached to the mclfree list, which is essentially singly linked. When you free a cluster already in the free list, you'll basically "lose" all the clusters sitting after that one cluster on the list. This then becomes virtually a "leak" and the system is royally borked. Somebody please commit this code. --Bosko -- Bosko Milekic * pages.infinit.net/bmilekic/index.html * www.technokratis.com bmilekic@dsuper.net * bmilekic@technokratis.com * b.milekic@marianopolis.edu "Give a man a fish and he will eat for a day. Teach him how to fish, and he will sit in a boat and drink beer all day." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005161720.KAA20390>