Date: Wed, 5 May 2004 09:26:32 +1000 From: Peter Jeremy <peter.jeremy@alcatel.com.au> To: Tim Kientzle <kientzle@freebsd.org> Cc: Andrew.Li@alcatel.com.au Subject: Re: cvs commit: src/usr.bin/tar fts.c fts.h Message-ID: <20040504232632.GA69416@gsmx07.alcatel.com.au> In-Reply-To: <200405041721.i44HL22l029797@repoman.freebsd.org> References: <200405041721.i44HL22l029797@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2004-May-04 10:21:02 -0700, Tim Kientzle <kientzle@freebsd.org> wrote: >kientzle 2004/05/04 10:21:02 PDT > > FreeBSD src repository > > Added files: > usr.bin/tar fts.c fts.h > Log: > Include local copies of fts.c and fts.h to be used ONLY on non-FreeBSD > systems. The fts.h here is an exact copy of include/fts.h (except for > an initial explanatory comment and the revision tags, of course). The > fts.c here is slightly modified from lib/libc/gen/fts.c so it can > compile correctly on non-FreeBSD systems. Since a colleague of mine has just finished porting fts(3) to Tru64, I was interested in the changes you needed to make. Having looked, it seems that your changes are primarily aimed at Linux compatibility rather than general portability - it's unlikely that your fts.c will be usable on anything other than Linux systems due to the '#ifdef LINUX' near the top - if this was '#ifndef __FreeBSD__', the portability would be enhanced. Also, why wasn't this done as a repocopy? This would have made it far easier to see the changes. -- Peter Jeremy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040504232632.GA69416>