Date: Fri, 3 Mar 2017 17:15:17 +0000 From: "wblock (Warren Block)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE Message-ID: <7346fe88c61d036fb70a339f11417bbc@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-zs5j6sjj2bwywywa3p22-req@FreeBSD.org> References: <differential-rev-PHID-DREV-zs5j6sjj2bwywywa3p22-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
wblock added inline comments. INLINE COMMENTS > ng_pppoe.4:108 > +It is possible to request a connection to a specific access concentrator, > +and/or set a specific host uniq tag, required by some Internet providers, > +using the "[AC-Name\\][Host-Uniq|]Service-Name" syntax. "host uniq" should be capitalized or otherwise identified with markup. Since it's used below, just be consistent and say `Host-Uniq`. > ng_pppoe.4:109 > +and/or set a specific host uniq tag, required by some Internet providers, > +using the "[AC-Name\\][Host-Uniq|]Service-Name" syntax. > +To set a binary Host-Uniq, it must be encoded as a hexadecimal lowercase The formatting looks odd, but is apparently meant to show that there is an optional AC-Name followed by double backslashes if present, followed by an optional Host-Uniq with a vertical bar if present. Does this render correctly? > ng_pppoe.4:113 > +"my-tag". > A session request packet will be broadcasted on the Ethernet. > This command uses the (Not yours, I know.) s/broadcasted/broadcast/ > ng_pppoe.4:117 > structure shown below. > +For example, the following init data argument can be used to > +connect to "my-isp" service with "my-host" uniq tag, accepting only s/the following/this/ > ng_pppoe.4:118 > +For example, the following init data argument can be used to > +connect to "my-isp" service with "my-host" uniq tag, accepting only > +"remote-ac" as access concentrator: Markup could show these with out-of-band highlighting rather than quotes. But I'm not sure which markup to use. > ng_pppoe.4:274 > +a HURL tag. > +The argument given is the URL that will be delivered to the client: > +.Bd -literal -offset indent Rewording: The argument is the URL to be delivered to the client: > ng_pppoe.4:281 > +a MOTM tag. > +The argument given is the message that will be delivered to the client: > +.Bd -literal -offset indent The argument is the message to be delivered to the client: > ng_pppoe.4:292 > +This command is sent to the node that started this session when a PADM > +message with a HURL tag is received, and contains a URL that the Host may > +pass to a web browser for presentation to the user. "may" usually implies "you have permission", while "can" means "it is possible". So: message with a HURL tag is received, and contains a URL which the Host can Should Host be capitalized? > ng_pppoe.4:297 > +message with a MOTM tag is received, and contains a Message Of The > +Minute that the Host may display to the user. > +.El As above: Minute which the Host can display to the user. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D9270 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: ale, #manpages, adrian, #network, julian, mav Cc: wblock, mav, poolroom_gmail.com, mandree, imp, freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7346fe88c61d036fb70a339f11417bbc>