Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Apr 2007 11:30:32 GMT
From:      Sepherosa Ziehau <sephe@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 117269 for review
Message-ID:  <200704031130.l33BUWom066072@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=117269

Change 117269 by sephe@sephe_zealot:sam_wifi on 2007/04/03 11:29:44

	Nuke unnecessary NULL checks.

Affected files ...

.. //depot/projects/wifi/sys/dev/wi/if_wi.c#31 edit

Differences ...

==== //depot/projects/wifi/sys/dev/wi/if_wi.c#31 (text+ko) ====

@@ -998,8 +998,7 @@
 
 			k = ieee80211_crypto_encap(ic, ni, m0);
 			if (k == NULL) {
-				if (ni != NULL)
-					ieee80211_free_node(ni);
+				ieee80211_free_node(ni);
 				m_freem(m0);
 				continue;
 			}
@@ -1019,8 +1018,7 @@
 		frmhdr.wi_dat_len = htole16(m0->m_pkthdr.len);
 		if (IFF_DUMPPKTS(ifp))
 			wi_dump_pkt(&frmhdr, NULL, -1);
-		if (ni != NULL)
-			ieee80211_free_node(ni);
+		ieee80211_free_node(ni);
 		if (wi_start_tx(ifp, &frmhdr, m0))
 			continue;
 		sc->sc_txnext = cur = (cur + 1) % sc->sc_ntxbuf;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704031130.l33BUWom066072>