Date: Thu, 5 Feb 2004 18:05:57 -0500 From: "Gordon Henriksen" <gordon@iclub.com> To: =?iso-8859-1?Q?'Ville_Skytt=E4'?= <scop@FreeBSD.org> Cc: freebsd-cvsweb@FreeBSD.org Subject: RE: [PATCH] Minimal support for paths with spaces Message-ID: <001101c3ec3c$9d3a1c50$d454e8c7@domain.ma.iclub.com> In-Reply-To: <1076021678.22286.64.camel@bobcat.mine.nu>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. ------=_NextPart_000_0012_01C3EC12.B4641450 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Ville Skytt=E4 wrote: > On Thu, 2004-02-05 at 22:05, Gordon Henriksen wrote: > > The attached patch allows me to use cvsweb.cgi to browse=20 > > folders and view/download files from my CVS repository which=20 > > contain spaces in their filenames. > [...] >=20 > You did not mention which version of CVSweb the patch was=20 > against (and the patch did not make it through to the list=20 > copy of the message I received, nor it is in the list=20 > archives). Anyway, basic use of files and dirs with spaces=20 > in their names is working fine here, using the latest=20 > FreeBSD-CVSweb beta, 2.9.2. Lots of work in proper path (and=20 > other general) escaping has been done in the 2.9.x betas. >=20 > Make sure that your patch is against that version (or CVS=20 > HEAD), and if it is still applicable, please resubmit. More=20 > info: http://www.freebsd.org/projects/cvsweb.html Ah! I've reattached it. Wonderful. No, I doubt it's still applicable, since it is quite a grossly basic fix against the stable release, cvsweb-2.0.6-- which I perhaps foolishly had opted for since I was just setting=20 up a service and didn't want to get embroiled in tracking=20 development for yet another utility... :) Are the betas roughly stable? I'm sure the escaping fixes are=20 grossly superior to this hack, but I also don't want to be=20 hitting 500's left and right. --=20 Gordon Henriksen IT Manager ICLUBcentral Inc. gordon@iclub.com ------=_NextPart_000_0012_01C3EC12.B4641450 Content-Type: application/octet-stream; name="cvsweb-spaces.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="cvsweb-spaces.patch" --- cvsweb.cgi Thu Sep 26 16:56:05 2002=0A= +++ /home/intra/cgi-bin/cvsweb.cgi Thu Feb 5 14:49:09 2004=0A= @@ -258,6 +258,8 @@=0A= $verbose =3D $v;=0A= $checkoutMagic =3D "~checkout~";=0A= $pathinfo =3D defined($ENV{PATH_INFO}) ? $ENV{PATH_INFO} : '';=0A= +$pathinfo =3D~ y/+/ /;=0A= +$pathinfo =3D~ s/%(..)/sprintf("%c", hex($1))/ge; # unquote %-quoted=0A= $where =3D $pathinfo;=0A= $doCheckout =3D ($where =3D~ m|^/$checkoutMagic/|);=0A= $where =3D~ s|^/$checkoutMagic/|/|;=0A= ------=_NextPart_000_0012_01C3EC12.B4641450--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?001101c3ec3c$9d3a1c50$d454e8c7>