Date: Tue, 5 Jun 2012 11:35:53 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "Andrey A. Chernov" <ache@freebsd.org> Subject: Re: svn commit: r236582 - head/lib/libc/stdlib Message-ID: <20120605083553.GH85127@deviant.kiev.zoral.com.ua> In-Reply-To: <4FCDBE69.6080906@FreeBSD.org> References: <201206042134.q54LYoVJ067685@svn.freebsd.org> <4FCDBE69.6080906@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--a8sldprk+5E/pDEv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 05, 2012 at 10:08:09AM +0200, Dimitry Andric wrote: > On 2012-06-04 23:34, Andrey A. Chernov wrote:> Author: ache > > Date: Mon Jun 4 21:34:49 2012 > > New Revision: 236582 > > URL: http://svn.freebsd.org/changeset/base/236582 > >=20 > > Log: > > 1) IEEE Std 1003.1-2008, "errno" section, is explicit that > > =20 > > "The setting of errno after a successful call to a function is > > unspecified unless the description of that function specifies that > > errno shall not be modified." > > =20 > > However, free() in IEEE Std 1003.1-2008 does not mention its interact= ion > > with errno, so MAY modify it after successful call > > (it depends on particular free() implementation, OS-specific, etc.). >=20 > Actually, it says the following: >=20 > RETURN VALUE >=20 > The free() function shall not return a value. >=20 > ERRORS >=20 > No errors are defined. >=20 > How much clearer do you want it? ;) Not to mention that the patch was committed to _our_ implementation of libc, which uses _our_ free, and not some abstract free(3). Our free changi= ng errno means that process state is so messed that worrying about realpath(3) correctness is beyond any expectations. I already described my POV to ache, but it seems that nobody listens. It ju= st a season, it seems. --a8sldprk+5E/pDEv Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk/NxOkACgkQC3+MBN1Mb4jWWQCfVddHYIiiIzDUp3qFjDfGqK77 5YUAn2E/APiLIwdFS3T4xB1Kka6goVaW =IzOm -----END PGP SIGNATURE----- --a8sldprk+5E/pDEv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120605083553.GH85127>